Differential D3290

Ensure PostgreSQL port is still up-to-date on FreeBSD
ClosedPublic
Actions

Authored by dereckson on Jan 15 2024, 21:37.

Details

Reviewers

dereckson

Maniphest Tasks

T1888: Add XML support on db-A PostgreSQL
T1943: Orbeon Forms trigger an error after application is submit

Commits

rOPSc680b42ecc99: Ensure PostgreSQL port is still up-to-date on FreeBSD

Summary

On FreeBSD, PostgreSQL is built through a port with XML support.

Those checks allow to notice two issues:

the port has been replaced by a system package and XML support is lost
the packages have been updated, and a library PostgreSQL uses bumped

Ref T1888
Ref T1943

Test Plan

Tested on db-A-001

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	roles/dbserver-pgsql/monitoring/files/check-postgresql-dependencies.py:61	E501	flake8 E501
Error	roles/dbserver-pgsql/monitoring/files/check-postgresql-xml-support.py:53	E501	flake8 E501

Unit

No Test Coverage

Branch

postgresql-monitoring

Build Status

Buildable 5208
Build 5489: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jan 15 2024, 21:37

dereckson created this revision.

Harbormaster completed remote builds in B5208: Diff 8470.Jan 15 2024, 21:37

black

Harbormaster completed remote builds in B5209: Diff 8471.Jan 15 2024, 21:39

packages_prefixes

Harbormaster completed remote builds in B5210: Diff 8472.Jan 15 2024, 21:41

For example, when ICU was updated:

db-A-001

$ ./check-postgresql-dependencies.py
ERROR: libicui18n.so.73 / libicuuc.so.73 are missing, PostgreSQL port MUST be rebuilt as soon as possible.

$ ./check-postgresql-dependencies.py
OK

Deployment

Complector

$ salt db-A-001 state.apply roles/dbserver-pgsql/monitoring
db-A-001:
----------
          ID: postgresql_monitoring_dependencies
    Function: pkg.installed
      Result: True
     Comment: The following packages were installed/updated: py39-pip
     Started: 21:40:59.667353
    Duration: 2132.32 ms
     Changes:
              ----------
              py39-pip:
                  ----------
                  new:
                      23.3.2
                  old:
----------
          ID: postgresql_monitoring_dependencies
    Function: pip.installed
        Name: lddcollect
      Result: True
     Comment: All packages were successfully installed
     Started: 21:41:02.873383
    Duration: 4538.261 ms
     Changes:
              ----------
              lddcollect==0.2.0:
                  Installed
----------
          ID: /usr/local/bin/check-postgresql-dependencies
    Function: file.managed
      Result: True
     Comment: File /usr/local/bin/check-postgresql-dependencies updated
     Started: 21:41:07.415152
    Duration: 35.588 ms
     Changes:
              ----------
              diff:
                  New file
              mode:
                  0755
----------
          ID: /usr/local/bin/check-postgresql-xml-support
    Function: file.managed
      Result: True
     Comment: File /usr/local/bin/check-postgresql-xml-support updated
     Started: 21:41:07.450907
    Duration: 32.835 ms
     Changes:
              ----------
              diff:
                  New file
              mode:
                  0755

Summary for db-A-001
------------
Succeeded: 4 (changed=4)
Failed:    0
------------
Total states run:     4
Total run time:   6.739 s

Complector

$ salt db-A-001 state.apply roles/dbserver-pgsql/monitoring
db-A-001:
----------
          ID: postgresql_monitoring_dependencies
    Function: pkg.installed
      Result: True
     Comment: All specified packages are already installed
     Started: 21:53:32.073163
    Duration: 79.827 ms
     Changes:
----------
          ID: postgresql_monitoring_dependencies
    Function: pip.installed
        Name: lddcollect
      Result: True
     Comment: Python package lddcollect was already installed
              All specified packages are already installed
     Started: 21:53:32.256201
    Duration: 1295.921 ms
     Changes:
----------
          ID: /usr/local/bin/check-postgresql-dependencies
    Function: file.managed
      Result: True
     Comment: File /usr/local/bin/check-postgresql-dependencies is in the correct state
     Started: 21:53:33.559697
    Duration: 22.171 ms
     Changes:
----------
          ID: /usr/local/bin/check-postgresql-xml-support
    Function: file.managed
      Result: True
     Comment: File /usr/local/bin/check-postgresql-xml-support is in the correct state
     Started: 21:53:33.582127
    Duration: 20.651 ms
     Changes:

Summary for db-A-001
------------
Succeeded: 4
Failed:    0
------------
Total states run:     4
Total run time:   1.419 s