Details

Reviewers

• dereckson

Maniphest Tasks

T1932: ViMbAdmin Provisioning

Commits

rOPSac27b81d07e0: Install PHP dependencies for ViMbAdmin

Summary

Ref T1932

Test Plan

Run the role with Salt on Hervil to check the already installed packages

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

packages

Build Status

Buildable 5316
Build 5597: arc lint + arc unit

Event Timeline

DorianWinty requested review of this revision.Jul 3 2024, 16:35

DorianWinty created this revision.

Harbormaster completed remote builds in B5312: Diff 8628.Jul 3 2024, 16:35

DorianWinty retitled this revision from Installation package for ViMbAdmin to Install package for ViMbAdmin.Jul 3 2024, 17:10

• dereckson added inline comments.Jul 3 2024, 21:08

roles/mailserver/vimbadmin/init.sls
26	I'd put them directly here instead of the pillar, it's not something we need to configure per machine, that will always be the same set of extensions. Also php83- can be found in /map.jinja

• dereckson requested changes to this revision.Jul 3 2024, 21:08

This revision now requires changes to proceed.Jul 3 2024, 21:08

Install package for ViMbAdmin

Harbormaster completed remote builds in B5315: Diff 8632.Jul 4 2024, 16:27

Harbormaster completed remote builds in B5316: Diff 8633.Jul 4 2024, 16:27

DorianWinty marked an inline comment as done.Jul 4 2024, 16:27

• dereckson added inline comments.Jul 4 2024, 16:43

roles/mailserver/vimbadmin/init.sls
13

Comments can also be in the state title, for example, if the state title is vimbadmin_install_packages, that makes that title its own comment.

update according comment

Harbormaster completed remote builds in B5317: Diff 8634.Jul 4 2024, 16:59

Test result of :
salt hervil state.sls roles/mailserver/vimbadmin/init

      ID: vimbadmin_install_packages                                                                                                                                                                
Function: pkg.installed                                                                         
  Result: True                                                                                  
 Comment: 2 targeted packages were installed/updated.                                           
          The following packages were already installed: php83-pdo_pgsql, php83-gettext, php83-xml
 Started: 17:13:04.125793                                                                       
Duration: 9672.066 ms   
 Changes:                                                                                       
          ----------                                                                            
          php83-pear:                                                                           
              ----------                                                                        
              new:                                                                              
                  1.10.13                                                                       
              old:                                                                              
          php83-pear-Services_JSON:
              ----------                                                                        
              new:                                                                              
                  1.0.3                                                                         
              old:                                                                              
          php83-pecl-memcache:                                                                  
              ----------                                                                        
              new:                                                                              
                  8.2                                                                           
              old: