Page MenuHomeDevCentral
Differential D3352

Install PHP dependencies for ViMbAdmin
ClosedPublic
Actions

Authored by DorianWinty on Jul 3 2024, 16:35.
Tags
None
Referenced Files
F3777530: D3352.diff
Mon, Nov 25, 01:42
Unknown Object (File)
Sat, Nov 23, 06:10
Unknown Object (File)
Fri, Nov 8, 16:37
Unknown Object (File)
Fri, Nov 8, 16:37
Unknown Object (File)
Fri, Nov 8, 16:37
Unknown Object (File)
Fri, Nov 8, 16:36
Unknown Object (File)
Fri, Nov 8, 16:36
Unknown Object (File)
Fri, Nov 8, 16:36
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1932: ViMbAdmin Provisioning
Commits
rOPSac27b81d07e0: Install PHP dependencies for ViMbAdmin
Summary

Ref T1932

Test Plan

Run the role with Salt on Hervil to check the already installed packages

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
packages
Build Status
Buildable 5330
Build 5611: arc lint + arc unit

Event Timeline

DorianWinty requested review of this revision.Jul 3 2024, 16:35
DorianWinty created this revision.
Harbormaster completed remote builds in B5312: Diff 8628.Jul 3 2024, 16:35
DorianWinty retitled this revision from Installation package for ViMbAdmin to Install package for ViMbAdmin.Jul 3 2024, 17:10
dereckson added inline comments.Jul 3 2024, 21:08
roles/mailserver/vimbadmin/init.sls
15

I'd put them directly here instead of the pillar, it's not something we need to configure per machine, that will always be the same set of extensions.

Also php83- can be found in /map.jinja

dereckson requested changes to this revision.Jul 3 2024, 21:08
This revision now requires changes to proceed.Jul 3 2024, 21:08
DorianWinty updated this revision to Diff 8632.Jul 4 2024, 16:27

Install package for ViMbAdmin

Harbormaster completed remote builds in B5315: Diff 8632.Jul 4 2024, 16:27
DorianWinty updated this revision to Diff 8633.Jul 4 2024, 16:27

aa

Harbormaster completed remote builds in B5316: Diff 8633.Jul 4 2024, 16:27
DorianWinty marked an inline comment as done.Jul 4 2024, 16:27
dereckson added inline comments.Jul 4 2024, 16:43
roles/mailserver/vimbadmin/init.sls
12
dereckson added a comment.Jul 4 2024, 16:44

Comments can also be in the state title, for example, if the state title is vimbadmin_install_packages, that makes that title its own comment.

DorianWinty updated this revision to Diff 8634.Jul 4 2024, 16:59
DorianWinty marked an inline comment as done.

update according comment

Harbormaster completed remote builds in B5317: Diff 8634.Jul 4 2024, 16:59
DorianWinty added a comment.Jul 4 2024, 17:16

Test result of :
salt hervil state.sls roles/mailserver/vimbadmin/init

      ID: vimbadmin_install_packages                                                                                                                                                                
Function: pkg.installed                                                                         
  Result: True                                                                                  
 Comment: 2 targeted packages were installed/updated.                                           
          The following packages were already installed: php83-pdo_pgsql, php83-gettext, php83-xml
 Started: 17:13:04.125793                                                                       
Duration: 9672.066 ms   
 Changes:                                                                                       
          ----------                                                                            
          php83-pear:                                                                           
              ----------                                                                        
              new:                                                                              
                  1.10.13                                                                       
              old:                                                                              
          php83-pear-Services_JSON:
              ----------                                                                        
              new:                                                                              
                  1.0.3                                                                         
              old:                                                                              
          php83-pecl-memcache:                                                                  
              ----------                                                                        
              new:                                                                              
                  8.2                                                                           
              old:
DorianWinty updated this revision to Diff 8635.Jul 4 2024, 17:23

aa

Harbormaster completed remote builds in B5318: Diff 8635.Jul 4 2024, 17:23
dereckson accepted this revision.Jul 4 2024, 17:38
dereckson retitled this revision from Install package for ViMbAdmin to Install PHP dependencies for ViMbAdmin.
dereckson edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jul 4 2024, 17:38
DorianWinty updated this revision to Diff 8649.Jul 5 2024, 19:07

cherry-pick

Harbormaster completed remote builds in B5330: Diff 8649.Jul 5 2024, 19:07
Closed by commit rOPSac27b81d07e0: Install PHP dependencies for ViMbAdmin (authored by DorianWinty). · Explain WhyJul 5 2024, 19:08
This revision was automatically updated to reflect the committed changes.
DorianWinty added a commit: rOPSac27b81d07e0: Install PHP dependencies for ViMbAdmin.

Revision Contents
Changeset List

PathSize
roles/
mailserver/
vimbadmin/
9 lines

Diff 8649

View Options

roles/mailserver/vimbadmin/init.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator