Avoid egrep in Salt code base
ClosedPublic
Actions

Authored by dereckson on Aug 3 2024, 13:09.

Details

Reviewers

DorianWinty

Maniphest Tasks

T1991: Context has again been lost on /var/log/www

Commits

rOPS4a03b8471a74: Avoid egrep in Salt code base

Summary

On recent Fedora/RHEL releases, egrep raises a deprecation warning.
That warning fails selinux.fcontext_policy_present invocations.

This is especially problematic for the SELinux module for paas-docker role.
Don't record SELinux context created several times issues with nginx logs.

Patch is not needed on FreeBSD servers as on that userland, egrep works fine.

Ref T1991

Test Plan

Apply on WindRiver, check it's ignored
Apply on Dwellers, run nginx config state

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

hotfix-salt-egrep

Build Status

Buildable 5400
Build 5681: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Aug 3 2024, 13:09

dereckson created this revision.

Harbormaster completed remote builds in B5400: Diff 8753.Aug 3 2024, 13:10

Complector

$ salt dwellers state.apply hotfixes/salt
dwellers:
----------
          ID: T1991_egrep_patch
    Function: file.patch
        Name: /opt/saltstack/salt/lib/python3.10/site-packages/salt
      Result: True
     Comment: Patch successfully applied
     Started: 16:15:53.189797
    Duration: 45.172 ms
     Changes:
              ----------
              pid:
                  4123780
              retcode:
                  0
              stderr:
              stdout:
                  patching file modules/csf.py
                  patching file modules/selinux.py

Summary for dwellers
------------
Succeeded: 1 (changed=1)
Failed:    0
------------
Total states run:     1
Total run time:  45.172 ms