Page MenuHomeDevCentral

Check if /etc/os-release is up-to-date on FreeBSD
ClosedPublic

Authored by dereckson on Aug 10 2024, 11:39.
Tags
None
Referenced Files
F3742310: D3416.id8869.diff
Thu, Nov 14, 04:26
F3741592: D3416.id8869.diff
Wed, Nov 13, 16:34
Unknown Object (File)
Tue, Nov 12, 19:38
Unknown Object (File)
Mon, Nov 11, 18:35
Unknown Object (File)
Thu, Nov 7, 22:42
Unknown Object (File)
Sun, Nov 3, 01:05
Unknown Object (File)
Thu, Oct 31, 08:23
Unknown Object (File)
Mon, Oct 28, 15:52
Subscribers
None

Details

Summary

Normally, /etc/os-release should be regenerated at boot time.
If we don't boot after a userland update, the file won't be updated either.

Raise a warning if the file is not up-to-date, a critical error if it doesn't exist.

Ref T2007.

Test Plan

Tested on WindRiver

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
check-os-release
Build Status
Buildable 5439
Build 5720: arc lint + arc unit

Event Timeline

dereckson created this revision.
dereckson edited the summary of this revision. (Show Details)
aceppaluni requested changes to this revision.EditedAug 12 2024, 01:08

Hi,
Should the shellcheck suggestion be added? I was not certain, If not, the code looks good :)

This revision now requires changes to proceed.Aug 12 2024, 01:08

The -x option allows shellcheck to source the external files (here /var/run/os-release), so it can know $VERSION exists for example:

$ shellcheck -x roles/core/monitoring/files/checks/nrpe/os_family/FreeBSD/check-os-release.sh

$ echo $?
0

Created T2010 to follow-up this shellcheck -x idea.

This revision is now accepted and ready to land.Aug 21 2024, 02:03