Handle organization and projects_v2 GitHub events
DraftPublic
Actions

Authored by dereckson on Tue, Oct 8, 22:43.

Tags

None

Referenced Files

	F3668011: D3500.id9009.diff
	Fri, Oct 18, 12:21

	Unknown Object (File)
	Thu, Oct 17, 12:04

	Unknown Object (File)
	Thu, Oct 17, 07:13

	Unknown Object (File)
	Mon, Oct 14, 22:13

	Unknown Object (File)
	Fri, Oct 11, 03:41

	Unknown Object (File)
	Fri, Oct 11, 03:12

	Unknown Object (File)
	Fri, Oct 11, 02:50

	Unknown Object (File)
	Thu, Oct 10, 23:25

View All 19 Files

Subscribers

None

This draft revision will be sent for review once this build passes: Build 5848: Build.

Details

Reviewers: None
Maniphest Tasks: T2050: organization.member_invited GitHub event triggers a 500

Summary

More events should be declared as administrative.

Fixes T2050.

Test Plan

Add unit tests for those cases

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

github-administrative-events

Unit TestsBroken
View All

	Time	Test
	0 ms	/home/dereckson/dev/nasqueron/notifications/notifications/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php

Event Timeline

dereckson created this revision.Tue, Oct 8, 22:43

dereckson retitled this revision from Handle organization and projects_v2 GitHub events More events should be declared as administative. to Handle organization and projects_v2 GitHub events.Tue, Oct 8, 22:44

dereckson edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

GitHub/

GitHubPayloadAnalyzer.php

2 lines

Diff 9009

View Options

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

Handle organization and projects_v2 GitHub eventsDraftPublicActions