Differential D3560

Create PHP event type classes to map JSON payload
Needs ReviewPublic
Actions

Authored by aceppaluni on Fri, Oct 25, 17:14.

Details

Reviewers

dereckson

Summary

Allows for decoding Json payload to existing classes

Test Plan

Tested using JsonMapper tool

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	github/src/Events/AlpBH.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/AlpCommitsH.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/AutoMerge.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/Label.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/License.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/Links.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/Milestone.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/Organization.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/PullRequest.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/PullRequestOpened.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/PushEvent.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/Repo.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols
Warning	github/src/Events/User.php:1	PHPCS.W.PSR1.Files.SideEffects.FoundWithSymbols	PSR1.Files.SideEffects.FoundWithSymbols

Unit

No Test Coverage

Branch

gitHubEvClasses

Build Status

Buildable 5649
Build 5931: arc lint + arc unit

Event Timeline

aceppaluni requested review of this revision.Fri, Oct 25, 17:14

aceppaluni created this revision.

Harbormaster completed remote builds in B5649: Diff 9148.Fri, Oct 25, 17:14

Updated php class files to resolve php lint issue

Harbormaster completed remote builds in B5650: Diff 9149.Fri, Oct 25, 17:57

dereckson retitled this revision from created php event type classes to map Json payload to Create PHP event type classes to map JSON payload.Fri, Oct 25, 22:19

dereckson edited the summary of this revision. (Show Details)

dereckson added inline comments.Fri, Oct 25, 22:23

github/src/Events/AlpBH.php
9	What means AlpBH?
github/src/Events/PullRequest.php
7	When you're in the same namespace, you can directly use a class without any need to import it before. Now, that makes me thing: perhaps it would be convenient to get a separation between base types (User, Repo) and events (Push, PullRequest)?
github/src/Events/PushEvent.php
24	What means AlpCommitsH?