Differential D1641

Allow to manipulate time ranges and check overlaps
ClosedPublic
Actions

Authored by dereckson on May 18 2018, 01:51.

Tags

None

Referenced Files

	F3751521: D1641.id.diff
	Sun, Nov 17, 09:45

	F3750857: D1641.id9223.diff
	Sun, Nov 17, 04:00

	F3750662: D1641.diff
	Sun, Nov 17, 02:33

	Unknown Object (File)
	Tue, Nov 12, 09:32

	Unknown Object (File)
	Tue, Nov 12, 03:40

	Unknown Object (File)
	Tue, Nov 12, 02:24

	Unknown Object (File)
	Tue, Nov 12, 02:23

	Unknown Object (File)
	Tue, Nov 12, 01:01

View All 25 Files

Subscribers

None

Details

Reviewers

Commits

rKOT6a9d07fcfe0e: Allow to manipulate time ranges and check overlaps
rKERUALD40d6f2ca3a04: Allow to manipulate time ranges and check overlaps

Test Plan

Unit tests provided.

Overlap test suite from https://codereview.stackexchange.com/questions/45784/test-2-time-ranges-to-see-if-they-overlap

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/DateTime/TimeRange.php:28	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

Test Failures

Branch

arcpatch-D1641

Build Status

Buildable 5681
Build 5963: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/home/dereckson/dev/keruald/omnitools/tests/DateTime/TimeRangeTest.php
	12 ms	Keruald\OmniTools\Tests\DateTime\TimeTest Keruald\OmniTools\Tests\DateTime\TimeTest::testParse Error: Non-static method Keruald\OmniTools\DateTime\Time::parse() cannot be called statically

Event Timeline

dereckson requested review of this revision.May 18 2018, 01:51

dereckson created this revision.

Harbormaster completed remote builds in B2572: Diff 4186.May 18 2018, 01:51

dereckson changed the visibility from "Public (No Login Required)" to "All Users".May 18 2018, 01:52

Allow HH:MM:SS format

Harbormaster completed remote builds in B2574: Diff 4189.May 18 2018, 05:14

Explain why we provide those ranges.

Harbormaster completed remote builds in B2575: Diff 4190.May 19 2018, 11:12

dereckson added inline comments.Sep 9 2018, 09:02

src/DateTime/Time.php
48	static
src/DateTime/TimeRange.php
38	static

Should be rebased and resubmitted against rKERUALD repository.

src/DateTime/Time.php
49	17h23m14s to parse too¿

dereckson changed the visibility from "All Users" to "Public (No Login Required)".Sun, Nov 10, 11:04

Rebased against current rKOT HEAD

Harbormaster completed remote builds in B5681: Diff 9217.Sun, Nov 10, 11:08

Moved to rKERUALD monorepo.

Harbormaster completed remote builds in B5682: Diff 9218.Sun, Nov 10, 11:13

static, count time range minutes, add tests, update to PHPUnit 10

Harbormaster completed remote builds in B5684: Diff 9221.Sun, Nov 10, 11:57

Simplify TimeRange::countMinutes

Harbormaster completed remote builds in B5685: Diff 9222.Sun, Nov 10, 12:05

Generic.Files.LineLength.MaxExceeded

Harbormaster completed remote builds in B5686: Diff 9223.Sun, Nov 10, 12:10

dereckson accepted this revision.Sun, Nov 10, 12:10

This revision is now accepted and ready to land.Sun, Nov 10, 12:10

Closed by commit rKERUALD40d6f2ca3a04: Allow to manipulate time ranges and check overlaps (authored by dereckson). · Explain WhySun, Nov 10, 12:10

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALD40d6f2ca3a04: Allow to manipulate time ranges and check overlaps.

dereckson added a commit: rKOT6a9d07fcfe0e: Allow to manipulate time ranges and check overlaps.Sun, Nov 10, 12:22

Revision Contents
Changeset List

Path

Size

src/

DateTime/

130 lines

91 lines

tests/

DateTime/

TimeRangeTest.php

93 lines

86 lines

Diff 9217

src/DateTime/Time.php

Loading...

src/DateTime/TimeRange.php

Loading...

tests/DateTime/TimeRangeTest.php

Loading...

tests/DateTime/TimeTest.php

Loading...