Page MenuHomeDevCentral

Allow to manipulate time ranges and check overlaps
ClosedPublic

Authored by dereckson on May 18 2018, 01:51.
Tags
None
Referenced Files
F9643089: D1641.id9223.diff
Wed, Jun 11, 00:20
F9642245: D1641.id9224.diff
Tue, Jun 10, 23:45
F9634200: D1641.id4186.diff
Tue, Jun 10, 17:46
F9624936: D1641.id9222.diff
Tue, Jun 10, 11:33
F9618592: D1641.id9217.diff
Tue, Jun 10, 06:54
F9618424: D1641.id9218.diff
Tue, Jun 10, 06:48
F9615512: D1641.id9222.diff
Tue, Jun 10, 04:10
F9615511: D1641.id9221.diff
Tue, Jun 10, 04:10
Subscribers
None

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/DateTime/TimeRange.php:28PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
Test Failures
Branch
arcpatch-D1641
Build Status
Buildable 5681
Build 5963: arc lint + arc unit

Unit TestsBroken

TimeTest
0 ms/home/dereckson/dev/keruald/omnitools/tests/DateTime/TimeRangeTest.php
12 msKeruald\OmniTools\Tests\DateTime\TimeTest
Keruald\OmniTools\Tests\DateTime\TimeTest::testParse Error: Non-static method Keruald\OmniTools\DateTime\Time::parse() cannot be called statically

Event Timeline

dereckson created this revision.
dereckson changed the visibility from "Public (No Login Required)" to "All Users".May 18 2018, 01:52

Explain why we provide those ranges.

src/DateTime/Time.php
48

static

src/DateTime/TimeRange.php
38

static

Should be rebased and resubmitted against rKERUALD repository.

src/DateTime/Time.php
49

17h23m14s to parse too¿

dereckson changed the visibility from "All Users" to "Public (No Login Required)".Nov 10 2024, 11:04

Rebased against current rKOT HEAD

static, count time range minutes, add tests, update to PHPUnit 10

Simplify TimeRange::countMinutes

Generic.Files.LineLength.MaxExceeded

This revision is now accepted and ready to land.Nov 10 2024, 12:10