Details

Reviewers

Commits

rKOT6a9d07fcfe0e: Allow to manipulate time ranges and check overlaps
rKERUALD40d6f2ca3a04: Allow to manipulate time ranges and check overlaps

Test Plan

Unit tests provided.

Overlap test suite from https://codereview.stackexchange.com/questions/45784/test-2-time-ranges-to-see-if-they-overlap

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Errors

Severity	Location	Code	Message
Error	omnitools/src/DateTime/TimeRange.php:21	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded

Unit

Tests Passed

Branch

omnitools-date-time-range

Build Status

Buildable 5684
Build 5966: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.May 18 2018, 01:51

dereckson created this revision.

Harbormaster completed remote builds in B2572: Diff 4186.May 18 2018, 01:51

dereckson changed the visibility from "Public (No Login Required)" to "All Users".May 18 2018, 01:52

Allow HH:MM:SS format

Harbormaster completed remote builds in B2574: Diff 4189.May 18 2018, 05:14

Explain why we provide those ranges.

Harbormaster completed remote builds in B2575: Diff 4190.May 19 2018, 11:12

dereckson added inline comments.Sep 9 2018, 09:02

src/DateTime/Time.php
47 ↗	(On Diff #4186)	static
src/DateTime/TimeRange.php
37 ↗	(On Diff #4186)	static

Should be rebased and resubmitted against rKERUALD repository.

src/DateTime/Time.php
48 ↗	(On Diff #4190)	17h23m14s to parse too¿

dereckson changed the visibility from "All Users" to "Public (No Login Required)".Sun, Nov 10, 11:04

Rebased against current rKOT HEAD

Harbormaster completed remote builds in B5681: Diff 9217.Sun, Nov 10, 11:08

Moved to rKERUALD monorepo.

Harbormaster completed remote builds in B5682: Diff 9218.Sun, Nov 10, 11:13

static, count time range minutes, add tests, update to PHPUnit 10

Harbormaster completed remote builds in B5684: Diff 9221.Sun, Nov 10, 11:57

Simplify TimeRange::countMinutes

Harbormaster completed remote builds in B5685: Diff 9222.Sun, Nov 10, 12:05

Generic.Files.LineLength.MaxExceeded

Harbormaster completed remote builds in B5686: Diff 9223.Sun, Nov 10, 12:10

dereckson accepted this revision.Sun, Nov 10, 12:10

This revision is now accepted and ready to land.Sun, Nov 10, 12:10

Closed by commit rKERUALD40d6f2ca3a04: Allow to manipulate time ranges and check overlaps (authored by dereckson). · Explain WhySun, Nov 10, 12:10

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALD40d6f2ca3a04: Allow to manipulate time ranges and check overlaps.

dereckson added a commit: rKOT6a9d07fcfe0e: Allow to manipulate time ranges and check overlaps.Sun, Nov 10, 12:22

Allow to manipulate time ranges and check overlaps
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 9221

omnitools/src/DateTime/Time.php

omnitools/src/DateTime/TimeRange.php

omnitools/tests/DateTime/TimeRangeTest.php

omnitools/tests/DateTime/TimeTest.php

Allow to manipulate time ranges and check overlapsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9221

omnitools/src/DateTime/Time.php

omnitools/src/DateTime/TimeRange.php

omnitools/tests/DateTime/TimeRangeTest.php

omnitools/tests/DateTime/TimeTest.php

Allow to manipulate time ranges and check overlaps
ClosedPublic
Actions

Revision Contents
Changeset List