Page MenuHomeDevCentral
Differential D3588

Update all the devdependencies
Needs RevisionPublic
Actions

Authored by MoustaphaAs on Wed, Nov 13, 12:34.
Tags
None
Referenced Files
F3750572: D3588.diff
Sun, Nov 17, 01:40
F3749178: D3588.diff
Sat, Nov 16, 13:26
Unknown Object (File)
Sat, Nov 16, 00:42
Unknown Object (File)
Fri, Nov 15, 23:04
Unknown Object (File)
Fri, Nov 15, 19:37
Unknown Object (File)
Fri, Nov 15, 16:49
Unknown Object (File)
Fri, Nov 15, 14:46
Unknown Object (File)
Fri, Nov 15, 14:33
View All 16 Files
Subscribers
None

Details

Reviewers
dereckson
DorianWinty
Summary

base on infra-www and check on https://www.npmjs.com/package/sass

Diff Detail

Repository
rUPSECTION Upsection
Lint
Lint Passed
Unit
No Test Coverage
Branch
up
Build Status
Buildable 5703
Build 5985: arc lint + arc unit

Event Timeline

MoustaphaAs requested review of this revision.Wed, Nov 13, 12:34
MoustaphaAs created this revision.
Harbormaster completed remote builds in B5701: Diff 9248.Wed, Nov 13, 12:34
dereckson requested changes to this revision.Wed, Nov 13, 19:28
dereckson added inline comments.
package.json
14

This block should be updated too.

Normally, if you run <code>make publish</code>, that should take care of this.

This revision now requires changes to proceed.Wed, Nov 13, 19:28
MoustaphaAs updated this revision to Diff 9249.Thu, Nov 14, 10:57
  • Update Foundation to 6.9.0
Harbormaster completed remote builds in B5702: Diff 9249.Thu, Nov 14, 10:57
MoustaphaAs updated this revision to Diff 9250.Thu, Nov 14, 11:06
  • Redirection of the gulfpipe test into /components/gulfpipe.js
Harbormaster completed remote builds in B5703: Diff 9250.Thu, Nov 14, 11:06
MoustaphaAs updated this revision to Diff 9252.Thu, Nov 14, 11:56

Keep only first commit

Harbormaster completed remote builds in B5705: Diff 9252.Thu, Nov 14, 11:56
MoustaphaAs added a child revision: D3590: Update Foundation to 6.9.0.Thu, Nov 14, 12:03
DorianWinty accepted this revision.Thu, Nov 14, 18:26
dereckson requested changes to this revision.Sat, Nov 16, 23:53
dereckson added inline comments.
components/gulpfile.js
139–148
[00:51:11] ReferenceError: imagemin is not defined
    at images …/gulpfile.babel.js:139:20)
143

Not aligned

This revision now requires changes to proceed.Sat, Nov 16, 23:53

Revision Contents
Changeset List

PathSize
components/
30 lines
60 lines
2 lines
template/
2 lines
src/
assets/
scss/
60 lines

Diff 9250

View Options

components/gulpfile.js

Loading...
View Options

components/package-template.json

Loading...
View Options

package.json

Loading...
View Options

template/Makefile

Loading...
View Options

template/src/assets/scss/_settings.scss

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator