Details

Reviewers

dereckson
DorianWinty

Diff Detail

Repository

rUPSECTION Upsection

Lint

Lint Passed

Unit

No Test Coverage

Branch

foundation

Build Status

Buildable 5737
Build 6019: arc lint + arc unit

Event Timeline

MoustaphaAs requested review of this revision.Thu, Nov 14, 12:00

MoustaphaAs created this revision.

Harbormaster completed remote builds in B5706: Diff 9253.Thu, Nov 14, 12:00

MoustaphaAs added a parent revision: D3588: Update all the devdependencies.Thu, Nov 14, 12:03

MoustaphaAs added a reviewer: dereckson.

DorianWinty accepted this revision.Thu, Nov 14, 18:27

This revision is now accepted and ready to land.Thu, Nov 14, 18:27

dereckson requested changes to this revision.Sat, Nov 16, 23:42

dereckson added inline comments.

template/src/assets/scss/_settings.scss
884	If this is now 57, what's the 56?

This revision now requires changes to proceed.Sat, Nov 16, 23:42

It's the 56 lapse of attention

Harbormaster completed remote builds in B5719: Diff 9273.Wed, Nov 20, 10:32

Using git bisect on foundation-sites repository, the 6.8.0 introduced a new section 56 "untitled" with a null primary color, pushing Xy Grid from 56 to 57, fixed afterwards by removing that extra section.

477b172480e6263c6f29315cc52a26c02cb56869 is the first bad commit
commit 477b172480e6263c6f29315cc52a26c02cb56869
Author: Joe Workman <joe@workmanmail.com>
Date:   Thu Aug 17 20:40:45 2023 -0700

    6.8.0 version bump

You can fix that by committing upstream a change in foundation/foundation-sites repository.