Differential D3681

Reformat shell scripts with 4 spaces
ClosedPublic
Actions

Authored by dereckson on Mon, Sep 15, 21:47.

Tags

None

Referenced Files

	F12205541: D3681.id9526.diff
	Mon, Oct 6, 12:59

	F12204906: D3681.id9526.diff
	Mon, Oct 6, 09:23

	Unknown Object (File)
	Tue, Sep 30, 11:42

	Unknown Object (File)
	Tue, Sep 30, 08:32

	Unknown Object (File)
	Mon, Sep 29, 03:18

	Unknown Object (File)
	Mon, Sep 29, 01:22

	Unknown Object (File)
	Sun, Sep 28, 23:10

	Unknown Object (File)
	Sun, Sep 28, 19:19

View All 40 Files

Subscribers

None

Details

Reviewers

Commits

rOPS70be53bcff6b: Reformat shell scripts with 4 spaces

Summary

Hunt tabs and other odd 2, 3 spaces cases in shell scripts

Per https://agora.nasqueron.org/Code_conventions

Test Plan

no-op

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	roles/paas-docker/devel/files/arc.sh:73	SC2164	SHELLCHECK
Warning	roles/paas-docker/devel/files/arc.sh:95	SC2046	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:85	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:111	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:111	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:111	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:111	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:111	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:111	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:113	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:113	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:113	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:113	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:113	SC2086	SHELLCHECK
Advice	roles/paas-docker/devel/files/arc.sh:113	SC2086	SHELLCHECK

Unit

No Test Coverage

Branch

reformat-spaces

Build Status

Buildable 5896
Build 6178: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mon, Sep 15, 21:47

dereckson created this revision.

Harbormaster completed remote builds in B5896: Diff 9526.Mon, Sep 15, 21:47

dereckson accepted this revision.Mon, Sep 15, 21:48

This revision is now accepted and ready to land.Mon, Sep 15, 21:48

No need to redeploy immediately as whitespaces are no-op, just a coherence check for the repository.

This revision was landed with ongoing or failed builds.Mon, Sep 15, 21:49

Closed by commit rOPS70be53bcff6b: Reformat shell scripts with 4 spaces (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPS70be53bcff6b: Reformat shell scripts with 4 spaces.

Revision Contents
Changeset List

Path

Size

roles/

core/

certificates/

files/

acmesh-nginxCheck.sh

14 lines

letsencrypt-renewal.sh

14 lines

motd/

files/

4 lines

network/

files/

Linux/

8 lines

mailserver/

dkim/

files/

bin/

get-dkim-dns-entries.sh

10 lines

get-dkim-key-table.sh

12 lines

get-dkim-signing-table.sh

12 lines

paas-docker/

devel/

files/

90 lines

phabricator/

arcanist/

files/

50 lines

containers/

files/

run-devcentral.sh

40 lines

shellserver/

user-session/

files/

32 lines

userland-software/

files/

install-eggdrop.sh

10 lines

vhosts/

files/

4 lines

vault/

bootstrap/

files/

vault-initialize.sh

38 lines

webserver-content/

org/

nasqueron/

files/

recipes/

admin.mail.nasqueron.org/

4 lines

Diff 9526

roles/core/certificates/files/acmesh-nginxCheck.sh

Loading...

roles/core/certificates/files/letsencrypt-renewal.sh

Loading...

roles/core/motd/files/motd.sh

Loading...

roles/core/network/files/Linux/routes.sh

Loading...

roles/mailserver/dkim/files/bin/get-dkim-dns-entries.sh

Loading...

roles/mailserver/dkim/files/bin/get-dkim-key-table.sh

Loading...

roles/mailserver/dkim/files/bin/get-dkim-signing-table.sh

Loading...

roles/paas-docker/devel/files/arc.sh

Loading...

roles/phabricator/arcanist/files/arc.sh

Loading...

roles/phabricator/containers/files/run-devcentral.sh

Loading...

roles/shellserver/user-session/files/whom-diff.sh

Loading...

roles/shellserver/userland-software/files/install-eggdrop.sh

Loading...

roles/shellserver/vhosts/files/vhosts.sh

Loading...

roles/vault/bootstrap/files/vault-initialize.sh

Loading...

roles/webserver-content/org/nasqueron/files/recipes/admin.mail.nasqueron.org/update.sh

Loading...