Page MenuHomeDevCentral
Differential D3731

Sort acme.sh and certbot files
ClosedPublic
Actions

Authored by dereckson on Oct 6 2025, 10:02.
Tags
None
Referenced Files
F24684829: D3731.id9651.diff
Thu, Mar 5, 05:07
Unknown Object (File)
Wed, Mar 4, 03:04
Unknown Object (File)
Tue, Mar 3, 20:50
Unknown Object (File)
Tue, Mar 3, 20:47
Unknown Object (File)
Tue, Mar 3, 14:41
Unknown Object (File)
Tue, Mar 3, 13:14
Unknown Object (File)
Tue, Mar 3, 12:49
Unknown Object (File)
Tue, Mar 3, 08:32
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T2043: Switch to acme.sh instead of certbot
Commits
rOPSa501e77b360a: Sort acme.sh and certbot files
Summary

This change sorts 11 configuration files into acmesh/ and certbot/ subfolders
to avoid to confuse both of them.

That will also make easier to delete roles/core/certificates/files/certbot
once every server and every domain are migrated to use acme.sh

Ref T2043

Test Plan
  • no-op for functionality
  • apply with test=True roles/certificates to check paths are correct

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Errors
SeverityLocationCodeMessage
Errorroles/core/certificates/files/certbot/acme-dns/edit-acme-dns-accounts.py:10E501flake8 E501
Errorroles/core/certificates/files/certbot/utilities/check-letsencrypt-certificates.py:11E501flake8 E501
Unit
No Test Coverage
Branch
sort-certificates-files
Build Status
Buildable 5982
Build 6264: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Oct 6 2025, 10:02
dereckson created this revision.
Harbormaster completed remote builds in B5981: Diff 9649.Oct 6 2025, 10:02
dereckson updated this revision to Diff 9650.Oct 6 2025, 10:08

Fix path

Harbormaster completed remote builds in B5982: Diff 9650.Oct 6 2025, 10:08
dereckson accepted this revision.Oct 6 2025, 10:10
This revision is now accepted and ready to land.Oct 6 2025, 10:10
This revision was landed with ongoing or failed builds.Oct 6 2025, 10:10
Closed by commit rOPSa501e77b360a: Sort acme.sh and certbot files (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOPSa501e77b360a: Sort acme.sh and certbot files.

Revision Contents
Changeset List

PathSize
roles/
core/
certificates/
4 lines
files/
acmesh/
nginxCheck.sh
acmesh-nginxCheck.sh
2 lines
acmesh/
syslog/
syslog.conf
acme.sh.conf
2 lines
certbot/
acme-dns/
2 lines
2 lines
2 lines
periodic/
2 lines
renewal/
standard.sh
letsencrypt-renewal.sh
2 lines
without-nginx.sh
letsencrypt-renewal-without-nginx.sh
2 lines
utilities/
9 lines
8 lines
syslog/
18 lines

Diff 9650

View Options

roles/core/certificates/acmesh.sls

Loading...
View Options

roles/core/certificates/files/730.letsencrypt

Loading...
View Options

roles/core/certificates/files/acme-dns-auth.py

Loading...
View Options

roles/core/certificates/files/acmesh-nginxCheck.sh

Loading...
View Options

roles/core/certificates/files/acmesh/nginxCheck.sh

Loading...
View Options

roles/core/certificates/files/acmesh/syslog.conf

Loading...
View Options

roles/core/certificates/files/certbot/acme-dns/acme-dns-auth.py

Loading...
View Options

roles/core/certificates/files/certbot/acme-dns/edit-acme-dns-accounts.py

Loading...
View Options

roles/core/certificates/files/certbot/cli.ini

Loading...
View Options

roles/core/certificates/files/certbot/periodic/730.letsencrypt

Loading...
View Options

roles/core/certificates/files/certbot/renewal/standard.sh

Loading...
View Options

roles/core/certificates/files/certbot/renewal/without-nginx.sh

Loading...
View Options

roles/core/certificates/files/certbot/utilities/check-letsencrypt-certificates.py

Loading...
View Options

roles/core/certificates/files/certbot/utilities/delete-certbot-certificate.sh

Loading...
View Options

roles/core/certificates/files/check-letsencrypt-certificates.py

Loading...
View Options

roles/core/certificates/files/cli.ini

Loading...
View Options

roles/core/certificates/files/delete-certbot-certificate.sh

Loading...
View Options

roles/core/certificates/files/edit-acme-dns-accounts.py

Loading...
View Options

roles/core/certificates/files/letsencrypt-renewal-without-nginx.sh

Loading...
View Options

roles/core/certificates/files/letsencrypt-renewal.sh

Loading...
View Options

roles/core/certificates/files/syslog/acme.sh.conf

Loading...
View Options

roles/core/certificates/letsencrypt.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator