Page MenuHomeDevCentral
Differential D3761

Mark explicitly nullable parameters
ClosedPublic
Actions

Authored by dereckson on Sat, Oct 18, 16:34.

Details

Reviewers
dereckson
Maniphest Tasks
T2144: Port Obsidian code to PHP 8.4
Commits
rOBSIDIAN17e867de7247: Mark explicitly nullable parameters
Summary

Nullable types have been introduced in PHP 7.1. This allows us to recognize
this application as written for PHP 7.0.

Old Smarty code isn't fixed, as we're going to move it as a Composer dependency.

Ref P375
Ref T2144

Diff Detail

Repository
rOBSIDIAN Obsidian Workspaces
Lint
No Lint Coverage
Unit
Test Failures
Branch
main
Build Status
Buildable 6027
Build 6311: arc lint + arc unit

Unit TestsBroken
View All

TimeTest
0 ms/Users/ssantoro/dev/nasqueron/obsidian/workspaces/tests/includes/database/DatabaseExceptionTest.php

Event Timeline

dereckson requested review of this revision.Sat, Oct 18, 16:34
dereckson created this revision.
Harbormaster completed remote builds in B6027: Diff 9743.Sat, Oct 18, 16:34
dereckson accepted this revision.Sat, Oct 18, 16:35
This revision is now accepted and ready to land.Sat, Oct 18, 16:35
This revision was landed with ongoing or failed builds.Sat, Oct 18, 16:35
Closed by commit rOBSIDIAN17e867de7247: Mark explicitly nullable parameters (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOBSIDIAN17e867de7247: Mark explicitly nullable parameters.

Revision Contents
Changeset List

PathSize
workspaces/
src/
includes/
collection/
4 lines
2 lines
database/
4 lines
4 lines
i18n/
4 lines

Diff 9743

View Options

workspaces/src/includes/collection/MongoDBCollectionIterator.php

Loading...
View Options

workspaces/src/includes/collection/MySQLCollection.php

Loading...
View Options

workspaces/src/includes/database/Database.php

Loading...
View Options

workspaces/src/includes/database/DatabaseException.php

Loading...
View Options

workspaces/src/includes/i18n/Language.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator