Page MenuHomeDevCentral
Feed All Stories

Mar 30 2018

dereckson accepted D1550: Create repository directory and provide build instructions.
$ salt-call --local state.apply roles/freebsd-repo
[…]
          ID: /var/repo/Makefile
    Function: file.managed
      Result: True
     Comment: File /var/repo/Makefile updated
     Started: 19:40:19.627520
    Duration: 97.707 ms
     Changes:
              ----------
              diff:
                  New file
              mode:
                  0644
Mar 30 2018, 19:55
dereckson updated the diff for D1550: Create repository directory and provide build instructions.

Fix Makefile

Mar 30 2018, 19:49
dereckson requested review of D1550: Create repository directory and provide build instructions.
Mar 30 2018, 19:42
dereckson committed rOPS7bd6bcfac9f5: Generate FreeBSD packages repository signing key (authored by dereckson).
Generate FreeBSD packages repository signing key
Mar 30 2018, 19:30
dereckson closed D1549: Generate FreeBSD packages repository signing key.
Mar 30 2018, 19:29
dereckson accepted D1549: Generate FreeBSD packages repository signing key.
$ salt-call --local state.apply roles/freebsd-repo
local:
----------
          ID: /usr/local/etc/freebsd-pkg-repo/key
    Function: file.directory
      Result: True
     Comment: Directory /usr/local/etc/freebsd-pkg-repo/key updated
     Started: 19:15:51.118448
    Duration: 38.505 ms
     Changes:
              ----------
              /usr/local/etc/freebsd-pkg-repo/key:
                  New Dir
----------
          ID: signing_key_generate_private
    Function: cmd.run
        Name: openssl genrsa -out repo.key 4096
      Result: True
     Comment: Command "openssl genrsa -out repo.key 4096" run
     Started: 19:15:51.160136
    Duration: 1480.753 ms
     Changes:
              ----------
              pid:
                  40367
              retcode:
                  0
              stderr:
                  Generating RSA private key, 4096 bit long modulus
                  ......++
                  ....................................++
                  e is 65537 (0x10001)
              stdout:
----------
          ID: signing_key_generate_public
    Function: cmd.run
        Name: openssl rsa -in repo.key -out repo.pub -pubout
      Result: True
     Comment: Command "openssl rsa -in repo.key -out repo.pub -pubout" run
     Started: 19:15:52.641676
    Duration: 151.185 ms
     Changes:
              ----------
              pid:
                  40370
              retcode:
                  0
              stderr:
                  writing RSA key
              stdout:
----------
          ID: /usr/local/etc/freebsd-pkg-repo/key/repo.key
    Function: file.managed
      Result: True
     Comment:
     Started: 19:15:52.793655
    Duration: 7.51 ms
     Changes:
              ----------
              mode:
                  0400
Mar 30 2018, 19:29
dereckson updated the diff for D1549: Generate FreeBSD packages repository signing key.

Set builder as user, so we don't run openssl and pkg as root

Mar 30 2018, 19:26
dereckson updated the diff for D1549: Generate FreeBSD packages repository signing key.

Create parent directory too.

Mar 30 2018, 19:15
dereckson updated the diff for D1549: Generate FreeBSD packages repository signing key.

fix syntax error

Mar 30 2018, 19:14
dereckson updated the diff for D1549: Generate FreeBSD packages repository signing key.

s/signing_key_dir/repo.signing_key_dir

Mar 30 2018, 19:13
dereckson requested review of D1549: Generate FreeBSD packages repository signing key.
Mar 30 2018, 19:12
dereckson committed rKCMD21b2d7f16ee9: Create simple commands with argc, argv and display (authored by dereckson).
Create simple commands with argc, argv and display
Mar 30 2018, 16:11
dereckson closed D1533: Create simple commands with argc, argv and display.
Mar 30 2018, 16:11
dereckson accepted D1533: Create simple commands with argc, argv and display.
Mar 30 2018, 16:09
dereckson updated the diff for D1533: Create simple commands with argc, argv and display.

PHPUnit ok with fix to Arcanist

Mar 30 2018, 16:09
Harbormaster failed remote builds in B2429: Diff 3952 for D1533: Create simple commands with argc, argv and display!
Mar 30 2018, 15:47
dereckson updated the diff for D1533: Create simple commands with argc, argv and display.

Update phpunit configuration

Mar 30 2018, 15:47
dereckson committed rNOTIFbd0dd208c396: Fix whitespace issue (authored by dereckson).
Fix whitespace issue
Mar 30 2018, 01:22
dereckson closed D1548: Fix whitespace issue.
Mar 30 2018, 01:22
dereckson accepted D1548: Fix whitespace issue.
Mar 30 2018, 01:21
dereckson requested review of D1548: Fix whitespace issue.
Mar 30 2018, 01:21
dereckson committed rNOTIF60f393712423: Enforce opening brace is on same line than method declaration (authored by dereckson).
Enforce opening brace is on same line than method declaration
Mar 30 2018, 00:53
dereckson closed D1547: Enforce opening brace is on same line than method declaration.
Mar 30 2018, 00:53
dereckson accepted D1547: Enforce opening brace is on same line than method declaration.
Mar 30 2018, 00:53
dereckson updated the test plan for D1547: Enforce opening brace is on same line than method declaration.
Mar 30 2018, 00:53
dereckson requested review of D1547: Enforce opening brace is on same line than method declaration.
Mar 30 2018, 00:52
dereckson committed rNOTIF1523ea67ce77: Ensure lines are at most 80 characters (authored by dereckson).
Ensure lines are at most 80 characters
Mar 30 2018, 00:41
dereckson closed D1545: Ensure lines are at most 80 characters.
Mar 30 2018, 00:41
dereckson accepted D1545: Ensure lines are at most 80 characters.
Mar 30 2018, 00:41
dereckson updated the diff for D1545: Ensure lines are at most 80 characters.

Don't touch porcelain Phabricator non refactored code, tests and code don't agree on return types

Mar 30 2018, 00:40
dereckson committed rNOTIF74227dcbd4de: Implement assertions specific to command display (authored by dereckson).
Implement assertions specific to command display
Mar 30 2018, 00:30
dereckson closed D1546: Implement assertions specific to command display.
Mar 30 2018, 00:30
dereckson accepted D1546: Implement assertions specific to command display.
Mar 30 2018, 00:29
Harbormaster failed remote builds in B2425: Diff 3944 for D1546: Implement assertions specific to command display!
Mar 30 2018, 00:28
dereckson requested review of D1546: Implement assertions specific to command display.
Mar 30 2018, 00:28
dereckson updated the diff for D1545: Ensure lines are at most 80 characters.

Tests too

Mar 30 2018, 00:21
dereckson updated the summary of D1545: Ensure lines are at most 80 characters.
Mar 30 2018, 00:02
dereckson updated the summary of D1545: Ensure lines are at most 80 characters.
Mar 30 2018, 00:01
dereckson updated the test plan for D1545: Ensure lines are at most 80 characters.
Mar 30 2018, 00:01
dereckson requested review of D1545: Ensure lines are at most 80 characters.
Mar 30 2018, 00:00

Mar 29 2018

dereckson committed rNOTIFbe3382f3ca03: Extract complex condition in its own method (authored by dereckson).
Extract complex condition in its own method
Mar 29 2018, 23:49
dereckson closed D1544: Extract complex condition in its own method.
Mar 29 2018, 23:49
dereckson accepted D1544: Extract complex condition in its own method.
Mar 29 2018, 23:49
dereckson updated the diff for D1544: Extract complex condition in its own method.

s/is/has

Mar 29 2018, 23:48
dereckson planned changes to D1544: Extract complex condition in its own method.
Mar 29 2018, 23:48
dereckson requested review of D1544: Extract complex condition in its own method.
Mar 29 2018, 23:47
dereckson committed rNOTIF09004d0d899c: Test and fix PhabricatorStory::mapPhabricatorFeedKey (authored by dereckson).
Test and fix PhabricatorStory::mapPhabricatorFeedKey
Mar 29 2018, 23:40
dereckson closed D1542: Test and fix PhabricatorStory::mapPhabricatorFeedKey.
Mar 29 2018, 23:40
dereckson accepted D1542: Test and fix PhabricatorStory::mapPhabricatorFeedKey.
Mar 29 2018, 23:40
dereckson updated the diff for D1542: Test and fix PhabricatorStory::mapPhabricatorFeedKey.

rebase

Mar 29 2018, 23:40
dereckson committed rNOTIFa93da5598a75: Fix whitespaces issue (authored by dereckson).
Fix whitespaces issue
Mar 29 2018, 23:37
dereckson closed D1543: Fix whitespaces issue.
Mar 29 2018, 23:37
dereckson accepted D1543: Fix whitespaces issue.
Mar 29 2018, 23:37
dereckson requested review of D1543: Fix whitespaces issue.
Mar 29 2018, 23:37
dereckson updated the diff for D1542: Test and fix PhabricatorStory::mapPhabricatorFeedKey.

Let story stay story, the goal is to rename storyFoo to foo.

Mar 29 2018, 23:36
dereckson requested review of D1542: Test and fix PhabricatorStory::mapPhabricatorFeedKey.
Mar 29 2018, 23:33
dereckson committed rNOTIFf19194a38dab: Test PhabricatorStory::getObjectType (authored by dereckson).
Test PhabricatorStory::getObjectType
Mar 29 2018, 23:26
dereckson closed D1541: Test PhabricatorStory::getObjectType.
Mar 29 2018, 23:26
dereckson accepted D1541: Test PhabricatorStory::getObjectType.
Mar 29 2018, 23:26
dereckson requested review of D1541: Test PhabricatorStory::getObjectType.
Mar 29 2018, 23:25
dereckson committed rNOTIF776383e86ab8: Prune unnecessary overridden method (authored by dereckson).
Prune unnecessary overridden method
Mar 29 2018, 22:10
dereckson closed D1540: Prune unnecessary overridden method.
Mar 29 2018, 22:10
dereckson accepted D1540: Prune unnecessary overridden method.

No op

Mar 29 2018, 22:09
dereckson requested review of D1540: Prune unnecessary overridden method.
Mar 29 2018, 22:09
dereckson committed rNOTIF0575d2497ed6: Avoid both assignment and comparison in same time (authored by dereckson).
Avoid both assignment and comparison in same time
Mar 29 2018, 21:56
dereckson closed D1538: Avoid both assignment and comparison in same time.
Mar 29 2018, 21:56
dereckson accepted D1538: Avoid both assignment and comparison in same time.
Mar 29 2018, 21:55
dereckson updated the diff for D1538: Avoid both assignment and comparison in same time.

Rebase

Mar 29 2018, 21:55
dereckson committed rNOTIF7b63e4d9345a: Handle case where Conduit repository.query doesn't send a value (authored by dereckson).
Handle case where Conduit repository.query doesn't send a value
Mar 29 2018, 21:54
dereckson closed T1387: ErrorException: count(): Parameter must be an array or an object that implements Countable as Resolved by committing rNOTIF7b63e4d9345a: Handle case where Conduit repository.query doesn't send a value.
Mar 29 2018, 21:54 · Notifications center, Technical debt
dereckson closed D1539: Handle case where Conduit repository.query doesn't send a value.
Mar 29 2018, 21:54
dereckson accepted D1539: Handle case where Conduit repository.query doesn't send a value.
Mar 29 2018, 21:54
dereckson claimed T1387: ErrorException: count(): Parameter must be an array or an object that implements Countable.
Mar 29 2018, 21:54 · Notifications center, Technical debt
dereckson added a revision to T1387: ErrorException: count(): Parameter must be an array or an object that implements Countable: D1539: Handle case where Conduit repository.query doesn't send a value.
Mar 29 2018, 21:53 · Notifications center, Technical debt
dereckson requested review of D1539: Handle case where Conduit repository.query doesn't send a value.
Mar 29 2018, 21:53
dereckson updated the task description for T1387: ErrorException: count(): Parameter must be an array or an object that implements Countable.
Mar 29 2018, 21:44 · Notifications center, Technical debt
dereckson updated the task description for T1387: ErrorException: count(): Parameter must be an array or an object that implements Countable.
Mar 29 2018, 21:44 · Notifications center, Technical debt
dereckson created T1387: ErrorException: count(): Parameter must be an array or an object that implements Countable.
Mar 29 2018, 21:44 · Notifications center, Technical debt
dereckson planned changes to D1538: Avoid both assignment and comparison in same time.

Not so no op

Mar 29 2018, 21:38
dereckson requested review of D1538: Avoid both assignment and comparison in same time.
Mar 29 2018, 21:34
Harbormaster failed remote builds in B2412: Diff 3924 for D1538: Avoid both assignment and comparison in same time!
Mar 29 2018, 21:34
dereckson committed rNOTIF1345f6ef37c7: Upgrade phan to a version compatible with PHP 7.2 (authored by dereckson).
Upgrade phan to a version compatible with PHP 7.2
Mar 29 2018, 21:24
dereckson closed D1537: Upgrade phan to a version compatible with PHP 7.2.
Mar 29 2018, 21:24
dereckson accepted D1537: Upgrade phan to a version compatible with PHP 7.2.
Mar 29 2018, 21:24
dereckson requested review of D1537: Upgrade phan to a version compatible with PHP 7.2.
Mar 29 2018, 21:24
dereckson committed rNOTIF85fc0f62b8e1: Enforce opening brace on same line than class declaration (authored by dereckson).
Enforce opening brace on same line than class declaration
Mar 29 2018, 21:15
dereckson closed D1536: Enforce opening brace on same line than class declaration.
Mar 29 2018, 21:15
dereckson accepted D1536: Enforce opening brace on same line than class declaration.
Mar 29 2018, 21:13
dereckson updated the diff for D1536: Enforce opening brace on same line than class declaration.

Restrict change to only the style fix

Mar 29 2018, 21:13
dereckson updated the summary of D1536: Enforce opening brace on same line than class declaration.
Mar 29 2018, 21:10
dereckson planned changes to D1536: Enforce opening brace on same line than class declaration.

Mixed with a composer version upgrade

Mar 29 2018, 21:09
Harbormaster failed remote builds in B2409: Diff 3919 for D1536: Enforce opening brace on same line than class declaration!
Mar 29 2018, 21:08
dereckson requested review of D1536: Enforce opening brace on same line than class declaration.
Mar 29 2018, 21:08
dereckson committed rNOTIF4371aede2901: Fix array indentation (authored by dereckson).
Fix array indentation
Mar 29 2018, 19:47
dereckson closed D1535: Fix array indentation.
Mar 29 2018, 19:47
dereckson accepted D1535: Fix array indentation.
Mar 29 2018, 19:47
dereckson requested review of D1535: Fix array indentation.
Mar 29 2018, 19:44
dereckson accepted D1533: Create simple commands with argc, argv and display.
Mar 29 2018, 18:14
dereckson updated the diff for D1533: Create simple commands with argc, argv and display.

phan, fix type issue

Mar 29 2018, 18:09
dereckson committed rOPS14ebe96219b5: Install php-ast on devserver role (authored by dereckson).
Install php-ast on devserver role
Mar 29 2018, 17:21