HomeDevCentral

Creating a rNotif image

Description

Creating a rNotif image

Summary:
An notification image.
Based on https://github.com/nasqueron/docker-cachet.
Resolves T647. Servers Notifications center Docker images

Test Plan:

  1. docker pull nasqueron/notifications
  2. docker run --name notifs -p 40080:80 nasqueron/notifications

Go to https://nasqueron.org:40080

Reviewers: dereckson

Subscribers: dereckson, Kaliiixx

Maniphest Tasks: T647

Differential Revision: http://devcentral.nasqueron.org/D246

Details

Auditors
dereckson
Provenance
SandlaythAuthored on
Differential Revision
D246: Creating a rNotif image
Branches
Unknown
Tags
Unknown
Tasks
T647: Create a Docker image for the Notifications Center

Event Timeline

Lack of application key

According https://laravel.com/docs/5.2#configuration Laravel uses an application key to encrypt data like users sessions.

This image doesn't provide an .env configuration file, so the php artisan key:generate step doesn't take effect.

Plans to provide a key:

  • We need to document in a README the need to provide a custom auth key in environment.
  • It could also be interesting in setup-container to create a .env file with only APP_KEY=SomeRandomKey, then call php artisan key:generate, but only do that when -e APP_KEY= hasn't been used at docker run. That will offer the benefit to let administrators choose if they want or not to maintain a key between deployment.

This installation constitutes as is a security risk, as the key is a known one.

Review policies

This change has been committed before getting proper review at D246.

Any change should be reviewed and:

  • accepted by another Nasqueron member in general cases
  • self-accepted if nobody else contribute to the current repository/project or if there is a real emergency like a security issue

The change here has been submitted to DevCentral, then immediately after committed, and so, hasn't been processed according the guidelines.

Reference: https://agora.nasqueron.org/How_to_contribute_code#Review_code

See also rNOTIF53de6354a0b3, which allowed the site to run without any exception in this scenario.