HomeDevCentral

Fix getObjectType and getProjectsPHIDs exceptions

Description

Fix getObjectType and getProjectsPHIDs exceptions

Summary:
Sometimes, a story is sent without any objectPHID field.
For example, test notifications to verify Aphlict settings have
no object attached.

This code handles those cases adding extra check for data presence.

Fixes T917.

Test Plan: Fire a failed notification

Reviewers: dereckson

Maniphest Tasks: T917

Differential Revision: https://devcentral.nasqueron.org/D489

Details

Event Timeline

dereckson added inline comments.
/app/Phabricator/PhabricatorStory.php
111

$this->data could sometimes be null, see T921, which caught it in tests.

All concerns with this commit have now been addressed.Feb 21 2022, 23:37