HomeDevCentral

New tool: Finger and Thimbl client
Concern Raised2b0b352cdd2eUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

New tool: Finger and Thimbl client

Event Timeline

dereckson added inline comments.
/finger/ThimblDocument.php
69

@return array

79

should be return string|null

/finger/thimbl.php
1

This tool would benefit (see next comment) to be structured with:

  • a controller logic
  • a form view
  • a timeline view
8

At this stage, $client could be null, if the address is invalid.

/includes/core2.php
71

the text to clean

89

Style to improve:

  • comments are third person (returns, encodes)
  • we generally use $matches instead of $captures
  • we generaly explicitely name callback functions as as callback
  • concatenation is a . b, not a.b

This betrays the import of a sample 3rd party code by the way, the source must be documented. In this case, Markus Jarderot should be credited according http://stackoverflow.com/a/1401716/1930997

rTOOLSbd10b3845fc6a60da91057761e1e06b994fb45e7 fixes both /finger/thimbl.php and the ThimblDocument.php L79 issues

@return array/Array issue reported in T127 and fixed in rTOOLSc46466f6c476.