New tool: Finger and Thimbl client
Description
Description
Details
Details
- Auditors
dereckson - Provenance
dereckson Authored on - Parents
- rTOOLS6e886dc3b71f: Improving footer: * Hg → Git * removing .php
- Branches
- Unknown
- Tags
- Tasks
- T128: A PHP fatal error occurs when the Thimbl client address is invalid instead to print a nicer error message.
T127: Code documentation: use array instead of Array
Event Timeline
/finger/ThimblDocument.php | ||
---|---|---|
69 | @return array | |
79 | should be return string|null | |
/finger/thimbl.php | ||
1 | This tool would benefit (see next comment) to be structured with:
| |
8 | At this stage, $client could be null, if the address is invalid. | |
/includes/core2.php | ||
71 | the text to clean | |
89 | Style to improve:
This betrays the import of a sample 3rd party code by the way, the source must be documented. In this case, Markus Jarderot should be credited according http://stackoverflow.com/a/1401716/1930997 |
Comment Actions
rTOOLSbd10b3845fc6a60da91057761e1e06b994fb45e7 fixes both /finger/thimbl.php and the ThimblDocument.php L79 issues