Page MenuHomeDevCentral
Differential D1118

Improve Arcanist shell scripts
ClosedPublic
Actions

Authored by dereckson on Oct 25 2017, 02:34.
Tags
None
Referenced Files
F10399641: D1118.diff
Fri, Jul 4, 22:34
Unknown Object (File)
Mon, Jun 30, 23:55
Unknown Object (File)
Sun, Jun 29, 03:19
Unknown Object (File)
Fri, Jun 27, 02:47
Unknown Object (File)
Wed, Jun 25, 02:30
Unknown Object (File)
Tue, Jun 24, 23:49
Unknown Object (File)
Tue, Jun 24, 22:20
Unknown Object (File)
Tue, Jun 24, 22:20
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rWK298b018a6ff3: Improve Arcanist shell scripts
Summary

Fixes suggested by shellcheck:

  • use $() instead of deprecated ``
  • avoid cat when pipelines can be used
  • quote variables
Test Plan

shellcheck

Diff Detail

Repository
rWK Wynter Kitro utilities
Lint
Lint Passed
SeverityLocationCodeMessage
Advicearcanist/arc-paste-file.sh:16SC2094SHELLCHECK
Advicearcanist/arc-paste-file.sh:16SC2094SHELLCHECK
Unit
No Test Coverage
Branch
shellcheck (branched from master)
Build Status
Buildable 1760
Build 2008: arc lint + arc unit

Event Timeline

dereckson created this revision.Oct 25 2017, 02:34
dereckson accepted this revision.Oct 25 2017, 02:35

We're sure it only reads.

This revision is now accepted and ready to land.Oct 25 2017, 02:35
Closed by commit rWK298b018a6ff3: Improve Arcanist shell scripts (authored by dereckson). · Explain WhyOct 25 2017, 02:35
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
arcanist/
8 lines
6 lines
8 lines

Diff 2853

View Options

arcanist/arc-paste-diff.sh

Loading...
View Options

arcanist/arc-paste-file.sh

Loading...
View Options

arcanist/arc-update-repo.sh

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator