Add shellcheck linter
ClosedPublic
Actions

Authored by dereckson on Nov 3 2017, 18:24.

Tags

Referenced Files

	F19110752: D1163.id.diff
	Tue, Dec 23, 21:34

	Unknown Object (File)
	Tue, Dec 23, 08:09

	Unknown Object (File)
	Tue, Dec 23, 02:46

	Unknown Object (File)
	Mon, Dec 22, 14:04

	Unknown Object (File)
	Mon, Dec 22, 10:02

	Unknown Object (File)
	Sat, Dec 20, 07:47

	Unknown Object (File)
	Sat, Dec 20, 03:26

	Unknown Object (File)
	Tue, Dec 16, 11:31

View All Files

Subscribers

Nasqueron Docker deployment squad

Details

Reviewers

dereckson

Commits

rDARC05c2c83f7a93: Add shellcheck linter

Summary

Setup similar to rOPSf637b1b858173

Test Plan

arc lint

Diff Detail

Repository

rDARC nasqueron/arcanist Docker image

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson created this revision.Nov 3 2017, 18:24

Herald added a project: Docker images. · View Herald TranscriptNov 3 2017, 18:24

Herald added a subscriber: Nasqueron Docker deployment squad. · View Herald Transcript

Harbormaster completed remote builds in B1829: Diff 2971.Nov 3 2017, 18:24

Works fine:

$ cat > foo.sh
#!/bin/sh

foo $1
$ git add foo.sh 
$ arc lint
>>> Lint for foo.sh:


   Advice  (SC2086) SHELLCHECK
    Double quote to prevent globbing and word splitting.

               1 #!/bin/sh
               2 
    >>>        3 foo $1
                     ^
 OKAY  No lint warnings.