Page MenuHomeDevCentral

Use consistent behavior between pubm:log and pub:log/dcc:log
ClosedPublic

Authored by dereckson on Mar 3 2018, 01:25.
Tags
None
Referenced Files
F9643126: D1389.id3546.diff
Wed, Jun 11, 00:21
F9642417: D1389.id3546.diff
Tue, Jun 10, 23:51
F9640504: D1389.id.diff
Tue, Jun 10, 22:35
F9636545: D1389.diff
Tue, Jun 10, 19:37
Unknown Object (File)
Mon, Jun 9, 23:24
Unknown Object (File)
Sun, Jun 8, 19:13
Unknown Object (File)
Tue, May 20, 04:39
Unknown Object (File)
Mon, May 12, 15:06
Subscribers
None

Details

Summary

Sure, pubm:log has already identified the component and the entry,
but this is not a valid reason to violate SRP and make this hard
to maintain.

An hint it's a bad idea? former code used $emitter, which isn't defined.

Test Plan

Tested all day on #nasqueron-ops

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
dereckson edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mar 3 2018, 01:25
This revision was automatically updated to reflect the committed changes.