Page MenuHomeDevCentral
Differential D1389

Use consistent behavior between pubm:log and pub:log/dcc:log
ClosedPublic
Actions

Authored by dereckson on Mar 3 2018, 01:25.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 08:14
Unknown Object (File)
Sun, Feb 9, 06:08
Unknown Object (File)
Sun, Feb 9, 06:08
Unknown Object (File)
Sun, Feb 9, 06:07
Unknown Object (File)
Wed, Feb 5, 16:15
Unknown Object (File)
Wed, Feb 5, 09:46
Unknown Object (File)
Fri, Jan 31, 17:14
Unknown Object (File)
Thu, Jan 30, 11:42
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rVIPER4349adfcb2f4: Use consistent behavior between pubm:log and pub:log/dcc:log
Summary

Sure, pubm:log has already identified the component and the entry,
but this is not a valid reason to violate SRP and make this hard
to maintain.

An hint it's a bad idea? former code used $emitter, which isn't defined.

Test Plan

Tested all day on #nasqueron-ops

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
serverslog (branched from master)
Build Status
Buildable 2179
Build 2427: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 3 2018, 01:25
dereckson created this revision.
Harbormaster completed remote builds in B2179: Diff 3545.Mar 3 2018, 01:25
dereckson accepted this revision.Mar 3 2018, 01:25
dereckson edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mar 3 2018, 01:25
Closed by commit rVIPER4349adfcb2f4: Use consistent behavior between pubm:log and pub:log/dcc:log (authored by dereckson). · Explain WhyMar 3 2018, 01:25
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Wearg/
3 lines

Diff 3545

View Options

Wearg/ServersLog.tcl

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator