Page MenuHomeDevCentral

Add phpcs in Composer
ClosedPublic

Authored by dereckson on Dec 31 2015, 19:19.
Tags
None
Referenced Files
F7108377: D139.diff
Sun, Apr 20, 20:09
F7052915: D139.id333.diff
Sat, Apr 19, 21:13
F7051121: D139.id334.diff
Sat, Apr 19, 20:29
Unknown Object (File)
Sat, Apr 19, 13:52
Unknown Object (File)
Sat, Apr 19, 11:49
Unknown Object (File)
Fri, Apr 18, 01:55
Unknown Object (File)
Wed, Apr 16, 14:27
Unknown Object (File)
Fri, Apr 11, 10:25
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIFd3c9caa36831: Add phpcs in Composer
Summary

We're going to add a phpcs check in Arcanist and have
already implemented it in the Jenkins tests job.

So, it makes sense to add it as a dev dependency in Composer.

Test Plan

Ensure Composer is valid JSON.

jsonlint composer.json

Update composer dependencies, then check phpcs binary exists.

composer update
ls -lh vendor/bin/phpcs

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
jenkins
Build Status
Buildable 174
Build 174: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Add phpcs in Composer.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2015, 19:20
This revision was automatically updated to reflect the committed changes.