Page MenuHomeDevCentral

Add phpcs in Composer
ClosedPublic

Authored by dereckson on Dec 31 2015, 19:19.
Tags
None
Referenced Files
F3777774: D139.diff
Mon, Nov 25, 02:33
Unknown Object (File)
Fri, Nov 22, 05:05
Unknown Object (File)
Tue, Nov 12, 18:48
Unknown Object (File)
Mon, Nov 11, 16:24
Unknown Object (File)
Sat, Nov 9, 14:57
Unknown Object (File)
Sat, Nov 9, 05:42
Unknown Object (File)
Fri, Nov 8, 20:35
Unknown Object (File)
Fri, Nov 8, 20:20
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIFd3c9caa36831: Add phpcs in Composer
Summary

We're going to add a phpcs check in Arcanist and have
already implemented it in the Jenkins tests job.

So, it makes sense to add it as a dev dependency in Composer.

Test Plan

Ensure Composer is valid JSON.

jsonlint composer.json

Update composer dependencies, then check phpcs binary exists.

composer update
ls -lh vendor/bin/phpcs

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to Add phpcs in Composer.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2015, 19:20
This revision was automatically updated to reflect the committed changes.