Page MenuHomeDevCentral
Differential D1605

Use an empty string as default encoding argument for encoding
ClosedPublic
Actions

Authored by dereckson on Apr 16 2018, 23:27.
Tags
None
Referenced Files
F19034782: D1605.diff
Tue, Dec 23, 02:55
F19012738: D1605.id4103.diff
Mon, Dec 22, 22:56
F18990600: D1605.id4103.diff
Mon, Dec 22, 19:00
F18963063: D1605.id.diff
Mon, Dec 22, 13:33
F18963057: D1605.id4103.diff
Mon, Dec 22, 13:33
Unknown Object (File)
Sun, Dec 21, 16:14
Unknown Object (File)
Fri, Dec 19, 18:49
Unknown Object (File)
Fri, Dec 19, 00:44
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rKOT6a62434da5e7: Use an empty string as default encoding argument for encoding
Summary

Nullable strings can be avoided when an empty string isn't a supported value.

This is a follow-up for 15ddc8ad7a9e.

Test Plan

New tests with default arguments provided.

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Passed
Unit
Tests Passed
Branch
master
Build Status
Buildable 2523
Build 2771: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
Strings/
Multibyte/
4 lines
4 lines
2 lines
tests/
Strings/
Multibyte/
6 lines

Diff 4102

View Options

src/Strings/Multibyte/OmniString.php

Loading...
View Options

src/Strings/Multibyte/StringPad.php

Loading...
View Options

src/Strings/Multibyte/StringUtilities.php

Loading...
View Options

tests/Strings/Multibyte/StringUtilitiesTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator