Differential D1605

Use an empty string as default encoding argument for encoding
ClosedPublic
Actions

Authored by dereckson on Apr 16 2018, 23:27.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rKOT6a62434da5e7: Use an empty string as default encoding argument for encoding

Summary

Nullable strings can be avoided when an empty string isn't a supported value.

This is a follow-up for 15ddc8ad7a9e.

Test Plan

New tests with default arguments provided.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson requested review of this revision.Apr 16 2018, 23:27

dereckson created this revision.

Harbormaster completed remote builds in B2523: Diff 4102.Apr 16 2018, 23:27

dereckson accepted this revision.Apr 16 2018, 23:28

This revision is now accepted and ready to land.Apr 16 2018, 23:28

Closed by commit rKOT6a62434da5e7: Use an empty string as default encoding argument for encoding (authored by dereckson). · Explain WhyApr 16 2018, 23:28

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/Strings/Multibyte/OmniString.php (4 lines)
M			src/Strings/Multibyte/StringPad.php (4 lines)
M			src/Strings/Multibyte/StringUtilities.php (2 lines)
M			tests/Strings/Multibyte/StringUtilitiesTest.php (6 lines)

Diff 4103

src/Strings/Multibyte/OmniString.php

Loading...

src/Strings/Multibyte/StringPad.php

Loading...

src/Strings/Multibyte/StringUtilities.php

Loading...

tests/Strings/Multibyte/StringUtilitiesTest.php

Loading...