Prune never executed code
ClosedPublic
Actions

Authored by dereckson on Jan 10 2016, 01:50.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIFbe0c324ed737: Prune never executed code

Summary

GitHubGateController::onPost contains an abort instruction.

This throws an exception, so return isn't needed.

This has been noticed look at the D213 test coverage.

Test Plan

Fire a GitHub valid payload
Fire a GitHub invalid payload
phpunit

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 506.Jan 10 2016, 01:50

dereckson retitled this revision from to Prune never executed code.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/6/ (console: https://ci.nasqueron.org/job/test-notifications-phab/6/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/6/ for more details.

dereckson accepted this revision.Jan 10 2016, 02:07

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 10 2016, 02:07

Closed by commit rNOTIFbe0c324ed737: Prune never executed code (authored by dereckson, committed by dereckson). · Explain WhyJan 10 2016, 02:07

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Http/

Controllers/

Gate/

GitHubGateController.php

1 line

Diff 507

View Options

app/Http/Controllers/Gate/GitHubGateController.php

Prune never executed codeClosedPublicActions