Page MenuHomeDevCentral

Build local URL
ClosedPublic

Authored by dereckson on Mar 17 2020, 03:21.

Details

Summary

The Request class allows to build server URL
while the URL class allow to encode local part.

Let's combine the two to allow to build local URLs.

Test Plan

Unit test provided.

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson created this revision.
src/HTTP/Requests/WithURL.php
102

Should work without this /

Need to be fixed at URL level.

dereckson retitled this revision from Build local URL to Build local URL.
dereckson edited the summary of this revision. (Show Details)

Rebase against / fix

This revision is now accepted and ready to land.Mar 18 2020, 02:38
This revision was landed with ongoing or failed builds.Mar 18 2020, 02:38
Closed by commit rKOT06ffd53b1ecf: Build local URL (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.