Build local URL
ClosedPublic
Actions

Authored by dereckson on Mar 17 2020, 03:21.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 15, 01:44

	Unknown Object (File)
	Tue, Apr 9, 06:51

	Unknown Object (File)
	Sun, Apr 7, 00:09

	Unknown Object (File)
	Fri, Apr 5, 14:19

	Unknown Object (File)
	Fri, Apr 5, 14:19

	Unknown Object (File)
	Fri, Apr 5, 14:19

	Unknown Object (File)
	Fri, Apr 5, 13:49

	Unknown Object (File)
	Fri, Apr 5, 12:55

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT06ffd53b1ecf: Build local URL

Summary

The Request class allows to build server URL
while the URL class allow to encode local part.

Let's combine the two to allow to build local URLs.

Test Plan

Unit test provided.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 17 2020, 03:21

dereckson created this revision.

dereckson added inline comments.Mar 18 2020, 02:34

src/HTTP/Requests/WithURL.php
102	Should work without this / Need to be fixed at URL level.

Rebase against / fix

Harbormaster completed remote builds in B3551: Diff 5759.Mar 18 2020, 02:37

dereckson accepted this revision.Mar 18 2020, 02:38

This revision is now accepted and ready to land.Mar 18 2020, 02:38

This revision was landed with ongoing or failed builds.Mar 18 2020, 02:38

Closed by commit rKOT06ffd53b1ecf: Build local URL (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT06ffd53b1ecf: Build local URL.

Revision Contents
Changeset List

Path

Size

src/

HTTP/

Requests/

WithURL.php

15 lines

tests/

HTTP/

Requests/

RequestTest.php

18 lines

Diff 5760

View Options

src/HTTP/Requests/WithURL.php