ClosedPublic
Actions

Authored by dereckson on May 30 2020, 23:08.

Tags

None

Referenced Files

	F2828548: D2290.id5768.diff
	Fri, Apr 19, 04:41

	Unknown Object (File)
	Sun, Apr 14, 23:35

	Unknown Object (File)
	Wed, Apr 10, 02:46

	Unknown Object (File)
	Sat, Apr 6, 09:33

	Unknown Object (File)
	Fri, Apr 5, 20:10

	Unknown Object (File)
	Mon, Apr 1, 22:21

	Unknown Object (File)
	Sun, Mar 31, 22:48

	Unknown Object (File)
	Sun, Mar 31, 22:47

View All Files

Subscribers

None

Details

Reviewers

amj

Commits

rLFfe6f26f02319: Avoid Box<Vec<_>>

Summary

As Vec is already a smart pointer, there isn't any need or benefit
to encapsulate it into another smart pointer.

Test Plan

Run a microservice, the routes are mounted as before.

Diff Detail

Repository

rLF Limiting Factor

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.May 30 2020, 23:08

dereckson created this revision.

Harbormaster completed remote builds in B3557: Diff 5768.May 30 2020, 23:08

for DefaultService too

Harbormaster completed remote builds in B3559: Diff 5770.May 31 2020, 00:00

amj accepted this revision.May 31 2020, 00:26

This revision is now accepted and ready to land.May 31 2020, 00:26

Closed by commit rLFfe6f26f02319: Avoid Box<Vec<_>> (authored by dereckson). · Explain WhyJun 1 2020, 17:31

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rLFfe6f26f02319: Avoid Box<Vec<_>>.

Revision Contents
Changeset List

Path

Size

src/

config.rs

4 lines

kernel.rs

4 lines

Diff 5771

View Options

src/config.rs