HTML implementation notes
HTML is more useful as a fragment than as full page,
to be able to be included in a regular application.
An entry can be divided as several paragraphs,
as it could represent several ideas.
Ref T1678
Details
Details
- Reviewers
dereckson - Maniphest Tasks
- T1678: Health check and reporting library
- Commits
- rKREPORT1d8d4a822974: Output report in HTML and Markdown
Unit tests for a regular report are provided.
Only missing some cases if the rapport, or a part of it like properties, is empty.
Diff Detail
Diff Detail
- Repository
- rKREPORT Keruald Report
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/Output/MarkdownOutput.php | ||
|---|---|---|
| 16 | Probably best to keep the same syntax everywhere. | |
| 29 | Should express the idea is the maximal length, not the properties count. What about something like $propertyMaxLength? | |
| 37 | To avoid such a long line, we can split it by column: $send[] = '| Property' . str_repeat(' ', $maxProp - 8)
.' | ' . str_repeat(' ', $maxValue) . ' |'; | |
| src/Output/HTMLOutput.php | ||
|---|---|---|
| 7–12 | Method names use camel case e.g. makeId | |
Comment Actions
camel case for makeId
modify the syntax for the $send[] and make the same everywere
to improve the readability
Comment Actions
Need to be rebased against D2503.
I can help rebasing if you push it with git branch -m report_show && git push origin report_show (let's avoid repport).
| src/Output/HTMLOutput.php | ||
|---|---|---|
| 12 | Ah yes thanks to thing about those ones too! Encoding for URL parts is different: you can use https://www.php.net/manual/en/function.urlencode.php For example we need to escape # ? & / but we don't need to escape <> | |
| 29 | Encoded twice, once here, once afterwards. As the URL part should be encoded with urlencode() we can just discard that one | |
| src/Output/MarkdownOutput.php | ||
|---|---|---|
| 36 | Ah by the way, you've min() and max() in a lot of languages: $propertyMaxLength = min($propertyMaxLength, 8); | |