Details

Reviewers

dereckson

Maniphest Tasks

T1725: Upgrade Laravel

Commits

rNOTIF327396a753b0: Update Laravel 8

Summary

Update to Laravel 8

Ref T1725

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

arcpatch-D2674

Build Status

Buildable 4198
Build 4450: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	18 ms	Nasqueron\Notifications\Tests\Actions\ActionsReportTest Nasqueron\Notifications\Tests\Actions\ActionsReportTest::testReport data/report.json and rendered report differ too much. Try $this->assertEquals($expectedReport, $actualReport) to see a diff.
	81 ms	Nasqueron\Notifications\Tests\Config\Reporting\IntegrationTest Nasqueron\Notifications\Tests\Config\Reporting\IntegrationTest::testConfig ErrorException: Undefined property: Illuminate\Http\JsonResponse::$response
	123 ms	Nasqueron\Notifications\Tests\Http\Controllers\GitHubGateControllerTest Nasqueron\Notifications\Tests\Http\Controllers\GitHubGateControllerTest::testGet Mockery\Exception\BadMethodCallException: Received Mockery_0_Illuminate_Contracts_Events_Dispatcher::dispatch(), but no expectations were specified
	118 ms	Nasqueron\Notifications\Tests\Jobs\NotifyNewCommitsToDiffusionTest
	130 ms	Nasqueron\Notifications\Tests\PayloadFullTest Nasqueron\Notifications\Tests\PayloadFullTest::testPost Error: Call to undefined method Nasqueron\Notifications\Tests\PayloadFullTest::seeJson()
		View Full Test Results (1 Failed · 6 Broken · 39 Passed)

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Harbormaster completed remote builds in B4197: Diff 6758.Apr 18 2022, 17:39

correct arc lint bug

Harbormaster completed remote builds in B4198: Diff 6759.Apr 18 2022, 20:37

DorianWinty added a project: Restricted Project.Apr 19 2022, 07:43

DorianWinty edited the summary of this revision. (Show Details)Apr 19 2022, 07:59

DorianWinty added a task: T1725: Upgrade Laravel.

adding codestyle
adding on the up of file the class that is use
adding using str_ instead of str::

Harbormaster completed remote builds in B4199: Diff 6760.Apr 19 2022, 18:45

wip

Harbormaster completed remote builds in B4200: Diff 6763.Apr 19 2022, 20:09

removing last str::

Harbormaster completed remote builds in B4202: Diff 6766.Apr 19 2022, 22:29

dereckson added a subscriber: dereckson.Apr 20 2022, 08:44

dereckson added inline comments.

app/Actions/AMQPAction.php
34 ↗	(On Diff #6766)	Not in the scope of the upgrade. Those esthetic changes are welcome, but: it's the other way around, ie the PREVIOUS `public function __construct )` was the correct one it should be done in a separate change against main branch (we can merge esthetic changes before upgrade without any issue)
app/Actions/Action.php
20 ↗	(On Diff #6766)	Probably created by a `phpcbf` with MediaWiki setting. The previous code was correct.
33 ↗	(On Diff #6766)	Same issue, previous file was fully correct in style.

correction err

Harbormaster completed remote builds in B4203: Diff 6767.Apr 22 2022, 15:50

correct tests
update some packages

Harbormaster completed remote builds in B4204: Diff 6768.Apr 22 2022, 22:10

correcting some Tests

Harbormaster completed remote builds in B4214: Diff 6779.May 4 2022, 19:39

correct to make work the tests

Harbormaster completed remote builds in B4215: Diff 6781.May 7 2022, 19:24

DorianWinty published this revision for review.May 7 2022, 19:31

DorianWinty retitled this revision from WIP Update Laravel 8 to Update Laravel 8.

modify test
remove unused use

Harbormaster completed remote builds in B4217: Diff 6785.May 7 2022, 20:44

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/253/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/253/console

adding back one removed file

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/254/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/254/console

Harbormaster failed remote builds in B4222: Diff 6790!May 8 2022, 14:52

dereckson mentioned this in D2683: Modernize build.xml.May 8 2022, 15:17

rebased

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/256/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/256/console

Harbormaster failed remote builds in B4225: Diff 6796!May 8 2022, 17:01

dereckson requested changes to this revision.May 8 2022, 17:33

dereckson added inline comments.

app/Analyzers/GitHub/Events/Event.php
34	Extraneous added line
44	extraneous added line
app/Analyzers/GitHub/Events/IssueCommentEvent.php
20	MediaWiki style
app/Analyzers/GitHub/Events/PullRequestEvent.php
18	MediaWiki
tests/TestCase.php
5	Restore that division Our app External libs Global space

This revision now requires changes to proceed.May 8 2022, 17:33

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/257/ for more details.

DorianWinty retitled this revision from Update Laravel 8 to WIP Update Laravel 8.May 9 2022, 18:14

modify folowing comments but need more to reading

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/258/ for more details.

Harbormaster completed remote builds in B4228: Diff 6799.May 9 2022, 18:31

DorianWinty retitled this revision from WIP Update Laravel 8 to Update Laravel 8.May 9 2022, 18:31

correcting style problem due to mediawiki phpcs style

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/259/ for more details.

Harbormaster completed remote builds in B4229: Diff 6800.May 10 2022, 17:38

correcting MW style to old style

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/260/ for more details.

Harbormaster completed remote builds in B4230: Diff 6801.May 10 2022, 17:54

phpcbf

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/261/ for more details.

Harbormaster completed remote builds in B4231: Diff 6802.May 10 2022, 18:05

dereckson requested changes to this revision.May 12 2022, 11:37

dereckson added inline comments.

app/Config/Reporting/BaseReportEntry.php
11 ↗	(On Diff #6802)	"public abstract" is more convenient as it's coherent with "public static": That would mean an order `<visibility> [special status] function <function name>`. More generally, run automated tools and accept ANY modification they do is a probably not a good idea, `git add -p` to filter the useful ones is very convenient with those "magic" tools.
app/Providers/RouteServiceProvider.php
36 ↗	(On Diff #6802)	MediaWiki style
composer.json
23–24	Two needs to be restored now we're up to date: phploc phpcpd
50	For phpmd, it's well ruleset.xml
tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php
68	MediaWiki style
tests/Analyzers/Phabricator/PhabricatorPayloadAnalyzerTest.php
90	MW
tests/Config/FeaturesTest.php
25 ↗	(On Diff #6802)	MW
tests/Console/Commands/NotificationsPayloadTest.php
51	MW (the two lines)
tests/Notifications/DockerHubNotificationTest.php
12 ↗	(On Diff #6802)	Extraneous line

This revision now requires changes to proceed.May 12 2022, 11:37

correction with the comments

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/262/ for more details.

Harbormaster completed remote builds in B4235: Diff 6806.May 13 2022, 06:54

dereckson accepted this revision.May 21 2022, 19:25

dereckson awarded a token.

This revision is now accepted and ready to land.May 21 2022, 19:25

This revision was landed with ongoing or failed builds.May 21 2022, 20:02

Closed by commit rNOTIF327396a753b0: Update Laravel 8 (authored by DorianWinty). · Explain Why

This revision was automatically updated to reflect the committed changes.

DorianWinty added a commit: rNOTIF327396a753b0: Update Laravel 8.

DorianWinty mentioned this in D2673: WIP Update Laravel 5.8.May 21 2022, 20:10

Update Laravel 8ClosedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 6759

app/Analyzers/GitHub/Events/Event.php

app/Analyzers/GitHub/Events/IssueCommentEvent.php

app/Analyzers/GitHub/Events/PullRequestEvent.php

app/Analyzers/GitHub/Events/PushEvent.php

app/Analyzers/GitHub/Events/RepositoryEvent.php

app/Analyzers/GitHub/Events/WithCommit.php

app/Analyzers/GitHub/Events/WithRef.php

app/Analyzers/GitHub/Events/WithRepoAndBranch.php

app/Analyzers/ItemGroupMapping.php

app/Contracts/APIClient.php

app/Contracts/APIFactory.php

app/Exceptions/Handler.php

app/Phabricator/PhabricatorAPI.php

app/Phabricator/PhabricatorAPIFactory.php

app/Phabricator/PhabricatorStory.php

app/Phabricator/ProjectsMap.php

app/Phabricator/ProjectsMapFactory.php

composer.json

config/app.php

tests/Actions/AMQPActionTest.php

tests/Actions/ActionErrorTest.php

tests/Actions/ActionsReportTest.php

tests/Actions/NotifyNewCommitsActionTest.php

tests/Actions/TriggerDockerHubBuildActionTest.php

tests/Analyzers/GitHub/Events/CreateEventTest.php

tests/Analyzers/GitHub/Events/DeleteEventTest.php

tests/Analyzers/GitHub/Events/EventTest.php

tests/Analyzers/GitHub/Events/IssueCommentEventTest.php

tests/Analyzers/GitHub/Events/PullRequestEventTest.php

tests/Analyzers/GitHub/Events/PushEventTest.php

tests/Analyzers/GitHub/Events/RepositoryEventTest.php

tests/Analyzers/GitHub/Events/StatusEventTest.php

tests/Analyzers/GitHub/Events/UnknownEventTest.php

tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php

tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfigurationTest.php

tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerTest.php

tests/Analyzers/PayloadAnalyzerConfigurationTest.php

tests/Analyzers/Phabricator/PhabricatorGroupMappingTest.php

tests/Analyzers/Phabricator/PhabricatorPayloadAnalyzerTest.php

tests/Config/Reporting/FeatureReportEntryTest.php

tests/Config/Reporting/IntegrationTest.php

tests/Config/Reporting/ServiceReportEntryTest.php

tests/Config/Services/ServiceTest.php

tests/Config/Services/ServicesTest.php

tests/Console/Commands/ConfigShowTest.php

tests/Console/Commands/ConfigValidateTest.php

tests/Console/Commands/NotificationsPayloadTest.php

tests/Console/Commands/PhabricatorProjectsMapTest.php

tests/Console/Commands/TestCase.php

tests/Console/KernelTest.php

tests/Exceptions/HandlerTest.php

tests/Http/Controllers/GitHubGateControllerTest.php

tests/Http/PayloadFullTest.php

tests/Http/PlaceholderTest.php

tests/Http/StatusTest.php

tests/Jobs/NotifyNewCommitsToDiffusionTest.php

tests/Phabricator/PhabricatorAPIExceptionTest.php

tests/Phabricator/PhabricatorAPIFactoryTest.php

tests/Phabricator/PhabricatorAPITest.php

tests/Phabricator/PhabricatorStoryTest.php

tests/Phabricator/ProjectsMapFactoryTest.php

tests/Phabricator/ProjectsMapTest.php

tests/Providers/ConfigTest.php

tests/Providers/EventServiceProviderTest.php

tests/TestCase.php

Update Laravel 8
ClosedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List