Page MenuHomeDevCentral

Update Laravel 8
ClosedPublic

Authored by DorianWinty on Apr 16 2022, 22:51.

Details

Summary

Update to Laravel 8

Ref T1725

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Errors
SeverityLocationCodeMessage
Errortests/Analyzers/GitHub/Events/EventTest.php:57PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/EventTest.php:71PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/IssueCommentEventTest.php:38PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/IssueCommentEventTest.php:39PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PullRequestEventTest.php:38PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PullRequestEventTest.php:39PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PullRequestEventTest.php:41PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PushEventTest.php:42PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PushEventTest.php:57PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PushEventTest.php:58PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Config/FeaturesTest.php:25PHPCS.E.Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterCommaGeneric.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma
Errortests/Http/PlaceholderTest.php:12PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errortests/Http/StatusTest.php:12PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errortests/Providers/ConfigTest.php:38PHPCS.E.Generic.Strings.UnnecessaryStringConcat.FoundGeneric.Strings.UnnecessaryStringConcat.Found
Errortests/Providers/EventServiceProviderTest.php:34PHPCS.E.Generic.Strings.UnnecessaryStringConcat.FoundGeneric.Strings.UnnecessaryStringConcat.Found
Errortests/TestCase.php:26PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Warningapp/Providers/RouteServiceProvider.php:37PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass
Unit
Tests Passed
Branch
arcpatch-D2674

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

adding codestyle
adding on the up of file the class that is use
adding using str_ instead of str::

dereckson added inline comments.
app/Actions/AMQPAction.php
34 ↗(On Diff #6766)

Not in the scope of the upgrade. Those esthetic changes are welcome, but:

  • it's the other way around, ie the PREVIOUS public function __construct ) was the correct one
  • it should be done in a separate change against main branch (we can merge esthetic changes before upgrade without any issue)
app/Actions/Action.php
20 ↗(On Diff #6766)

Probably created by a phpcbf with MediaWiki setting.

The previous code was correct.

33 ↗(On Diff #6766)

Same issue, previous file was fully correct in style.

correct tests
update some packages

correct to make work the tests

DorianWinty retitled this revision from WIP Update Laravel 8 to Update Laravel 8.

modify test
remove unused use

adding back one removed file

dereckson requested changes to this revision.May 8 2022, 17:33
dereckson added inline comments.
app/Analyzers/GitHub/Events/Event.php
34

Extraneous added line

49

extraneous added line

app/Analyzers/GitHub/Events/IssueCommentEvent.php
18

MediaWiki style

app/Analyzers/GitHub/Events/PullRequestEvent.php
18

MediaWiki

tests/TestCase.php
5

Restore that division

  1. Our app
  2. External libs
  3. Global space
This revision now requires changes to proceed.May 8 2022, 17:33
DorianWinty retitled this revision from Update Laravel 8 to WIP Update Laravel 8.May 9 2022, 18:14
DorianWinty marked 5 inline comments as done.

modify folowing comments but need more to reading

DorianWinty retitled this revision from WIP Update Laravel 8 to Update Laravel 8.May 9 2022, 18:31

correcting style problem due to mediawiki phpcs style

correcting MW style to old style

dereckson requested changes to this revision.May 12 2022, 11:37
dereckson added inline comments.
app/Config/Reporting/BaseReportEntry.php
11–13

"public abstract" is more convenient as it's coherent with "public static":

That would mean an order <visibility> [special status] function <function name>.

More generally, run automated tools and accept ANY modification they do is a probably not a good idea, git add -p to filter the useful ones is very convenient with those "magic" tools.

app/Providers/RouteServiceProvider.php
36–37

MediaWiki style

composer.json
23–24

Two needs to be restored now we're up to date:

  • phploc
  • phpcpd
53

For phpmd, it's well ruleset.xml

tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php
68

MediaWiki style

tests/Analyzers/Phabricator/PhabricatorPayloadAnalyzerTest.php
90

MW

tests/Config/FeaturesTest.php
25

MW

tests/Console/Commands/NotificationsPayloadTest.php
49

MW (the two lines)

tests/Notifications/DockerHubNotificationTest.php
10

Extraneous line

This revision now requires changes to proceed.May 12 2022, 11:37
DorianWinty marked 9 inline comments as done.

correction with the comments

This revision is now accepted and ready to land.May 21 2022, 19:25
This revision was landed with ongoing or failed builds.May 21 2022, 20:02
This revision was automatically updated to reflect the committed changes.