Paths

Table of Contentst

Differential D2674

Update Laravel 8
ClosedPublic
Actions

Authored by DorianWinty on Apr 16 2022, 22:51.

Tags

Referenced Files

	F3763261: D2674.id6799.diff
	Thu, Nov 21, 21:56

	F3763250: D2674.id6781.diff
	Thu, Nov 21, 21:51

	F3762955: D2674.diff
	Thu, Nov 21, 18:08

	F3762864: D2674.id6785.largetrue.diff
	Thu, Nov 21, 16:47

	Unknown Object (File)
	Wed, Nov 20, 18:51

	Unknown Object (File)
	Wed, Nov 20, 05:37

	Unknown Object (File)
	Tue, Nov 19, 16:56

	Unknown Object (File)
	Tue, Nov 19, 13:04

Subscribers

Tokens

"Yellow Medal" token, awarded by dereckson.

Details

Reviewers

Maniphest Tasks

T1725: Upgrade Laravel

Commits

rNOTIF327396a753b0: Update Laravel 8

Summary

Update to Laravel 8

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Errors

Severity	Location	Code	Message
Error	tests/Analyzers/GitHub/Events/EventTest.php:57	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/EventTest.php:71	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/IssueCommentEventTest.php:38	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/IssueCommentEventTest.php:39	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/PullRequestEventTest.php:38	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/PullRequestEventTest.php:39	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/PullRequestEventTest.php:41	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/PushEventTest.php:42	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/PushEventTest.php:57	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Analyzers/GitHub/Events/PushEventTest.php:58	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	tests/Config/FeaturesTest.php:25	PHPCS.E.Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma	Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma
Error	tests/Http/PlaceholderTest.php:12	PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine	Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Error	tests/Http/StatusTest.php:12	PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine	Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Error	tests/Providers/ConfigTest.php:38	PHPCS.E.Generic.Strings.UnnecessaryStringConcat.Found	Generic.Strings.UnnecessaryStringConcat.Found
Error	tests/Providers/EventServiceProviderTest.php:34	PHPCS.E.Generic.Strings.UnnecessaryStringConcat.Found	Generic.Strings.UnnecessaryStringConcat.Found
Error	tests/TestCase.php:26	PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine	Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Warning	app/Providers/RouteServiceProvider.php:37	PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass	Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass

Unit

Tests Passed

Branch

arcpatch-D2674

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Harbormaster completed remote builds in B4197: Diff 6758.Apr 18 2022, 17:39

correct arc lint bug

Harbormaster completed remote builds in B4198: Diff 6759.Apr 18 2022, 20:37

DorianWinty added a project: Restricted Project.Apr 19 2022, 07:43

DorianWinty edited the summary of this revision. (Show Details)Apr 19 2022, 07:59

DorianWinty added a task: T1725: Upgrade Laravel.

adding codestyle
adding on the up of file the class that is use
adding using str_ instead of str::

Harbormaster completed remote builds in B4199: Diff 6760.Apr 19 2022, 18:45

wip

Harbormaster completed remote builds in B4200: Diff 6763.Apr 19 2022, 20:09

removing last str::

Harbormaster completed remote builds in B4202: Diff 6766.Apr 19 2022, 22:29

dereckson added a subscriber: dereckson.Apr 20 2022, 08:44

dereckson added inline comments.

app/Actions/AMQPAction.php
34 ↗	(On Diff #6766)	Not in the scope of the upgrade. Those esthetic changes are welcome, but: it's the other way around, ie the PREVIOUS `public function __construct )` was the correct one it should be done in a separate change against main branch (we can merge esthetic changes before upgrade without any issue)
app/Actions/Action.php
20 ↗	(On Diff #6766)	Probably created by a `phpcbf` with MediaWiki setting. The previous code was correct.
33 ↗	(On Diff #6766)	Same issue, previous file was fully correct in style.

correction err

Harbormaster completed remote builds in B4203: Diff 6767.Apr 22 2022, 15:50

correct tests
update some packages

Harbormaster completed remote builds in B4204: Diff 6768.Apr 22 2022, 22:10

correcting some Tests

Harbormaster completed remote builds in B4214: Diff 6779.May 4 2022, 19:39

correct to make work the tests

Harbormaster completed remote builds in B4215: Diff 6781.May 7 2022, 19:24

DorianWinty published this revision for review.May 7 2022, 19:31

DorianWinty retitled this revision from WIP Update Laravel 8 to Update Laravel 8.

modify test
remove unused use

Harbormaster completed remote builds in B4217: Diff 6785.May 7 2022, 20:44

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/253/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/253/console

adding back one removed file

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/254/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/254/console

Harbormaster failed remote builds in B4222: Diff 6790!May 8 2022, 14:52

dereckson mentioned this in D2683: Modernize build.xml.May 8 2022, 15:17

rebased

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/256/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/256/console

Harbormaster failed remote builds in B4225: Diff 6796!May 8 2022, 17:01

dereckson requested changes to this revision.May 8 2022, 17:33

dereckson added inline comments.

app/Analyzers/GitHub/Events/Event.php
34	Extraneous added line
49	extraneous added line
app/Analyzers/GitHub/Events/IssueCommentEvent.php
18	MediaWiki style
app/Analyzers/GitHub/Events/PullRequestEvent.php
18	MediaWiki
tests/TestCase.php
5	Restore that division Our app External libs Global space

This revision now requires changes to proceed.May 8 2022, 17:33

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/257/ for more details.

DorianWinty retitled this revision from Update Laravel 8 to WIP Update Laravel 8.May 9 2022, 18:14

modify folowing comments but need more to reading

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/258/ for more details.

Harbormaster completed remote builds in B4228: Diff 6799.May 9 2022, 18:31

DorianWinty retitled this revision from WIP Update Laravel 8 to Update Laravel 8.May 9 2022, 18:31

correcting style problem due to mediawiki phpcs style

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/259/ for more details.

Harbormaster completed remote builds in B4229: Diff 6800.May 10 2022, 17:38

correcting MW style to old style

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/260/ for more details.

Harbormaster completed remote builds in B4230: Diff 6801.May 10 2022, 17:54

phpcbf

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/261/ for more details.

Harbormaster completed remote builds in B4231: Diff 6802.May 10 2022, 18:05

dereckson requested changes to this revision.May 12 2022, 11:37

dereckson added inline comments.

app/Config/Reporting/BaseReportEntry.php
11–13	"public abstract" is more convenient as it's coherent with "public static": That would mean an order `<visibility> [special status] function <function name>`. More generally, run automated tools and accept ANY modification they do is a probably not a good idea, `git add -p` to filter the useful ones is very convenient with those "magic" tools.
app/Providers/RouteServiceProvider.php
36–37	MediaWiki style
composer.json
23–24	Two needs to be restored now we're up to date: phploc phpcpd
53	For phpmd, it's well ruleset.xml
tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php
68	MediaWiki style
tests/Analyzers/Phabricator/PhabricatorPayloadAnalyzerTest.php
90	MW
tests/Config/FeaturesTest.php
25	MW
tests/Console/Commands/NotificationsPayloadTest.php
49	MW (the two lines)
tests/Notifications/DockerHubNotificationTest.php
10	Extraneous line

This revision now requires changes to proceed.May 12 2022, 11:37

correction with the comments

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/262/ for more details.

Harbormaster completed remote builds in B4235: Diff 6806.May 13 2022, 06:54

dereckson accepted this revision.May 21 2022, 19:25

dereckson awarded a token.

This revision is now accepted and ready to land.May 21 2022, 19:25

This revision was landed with ongoing or failed builds.May 21 2022, 20:02

Closed by commit rNOTIF327396a753b0: Update Laravel 8 (authored by DorianWinty). · Explain Why

This revision was automatically updated to reflect the committed changes.

DorianWinty added a commit: rNOTIF327396a753b0: Update Laravel 8.

DorianWinty mentioned this in D2673: WIP Update Laravel 5.8.May 21 2022, 20:10

Revision Contents
Changeset List

Path

Size

8 lines

app/

Analyzers/

BasePayloadAnalyzer.php

9 lines

DockerHub/

BuildFailureEvent.php

2 lines

GitHub/

Events/

23 lines

IssueCommentEvent.php

6 lines

PullRequestEvent.php

2 lines

2 lines

8 lines

WithRepoAndBranch.php

2 lines

GitHubPayloadAnalyzer.php

2 lines

ItemGroupMapping.php

5 lines

Jenkins/

JenkinsPayloadAnalyzer.php

2 lines

Config/

2 lines

Reporting/

BaseReportEntry.php

5 lines

ConfigReport.php

5 lines

ServiceReportEntry.php

2 lines

Services/

2 lines

Console/

Commands/

ConfigValidate.php

3 lines

NotificationsPayload.php

6 lines

PhabricatorProjectsMap.php

4 lines

Contracts/

4 lines

2 lines

Events/

DockerHubPayloadEvent.php

1 line

GitHubPayloadEvent.php

1 line

JenkinsPayloadEvent.php

1 line

NotificationEvent.php

4 lines

PhabricatorPayloadEvent.php

3 lines

ReportEvent.php

3 lines

Exceptions/

19 lines

Facades/

3 lines

Http/

Controllers/

8 lines

Gate/

DockerHubGateController.php

8 lines

GateController.php

13 lines

GitHubGateController.php

10 lines

JenkinsGateController.php

8 lines

NotificationGateController.php

15 lines

PhabricatorGateController.php

8 lines

3 lines

Jobs/

FireDockerHubNotification.php

10 lines

FireGitHubNotification.php

10 lines

FireJenkinsNotification.php

10 lines

FirePhabricatorNotification.php

12 lines

NotifyNewCommitsToDiffusion.php

10 lines

SendMessageToBroker.php

10 lines

TriggerDockerHubBuild.php

10 lines

Listeners/

AMQPEventListener.php

25 lines

DockerHubListener.php

25 lines

LastPayloadSaver.php

26 lines

NotificationListener.php

39 lines

PhabricatorListener.php

21 lines

Notifications/

DockerHubNotification.php

3 lines

Phabricator/

PhabricatorAPI.php

3 lines

PhabricatorStory.php

2 lines

ProjectsMap.php

5 lines

ProjectsMapFactory.php

4 lines

Providers/

DockerHubServiceProvider.php

3 lines

EventServiceProvider.php

56 lines

MailgunServiceProvider.php

3 lines

PhabricatorAPIServiceProvider.php

2 lines

PhabricatorProjectsMapServiceProvider.php

2 lines

ReportServiceProvider.php

2 lines

RouteServiceProvider.php

12 lines

35 lines

config/

20 lines

8 lines

tests/

Actions/

AMQPActionTest.php

4 lines

ActionErrorTest.php

4 lines

ActionsReportTest.php

12 lines

NotifyNewCommitsActionTest.php

4 lines

TriggerDockerHubBuildActionTest.php

4 lines

Analyzers/

GitHub/

Events/

CreateEventTest.php

7 lines

DeleteEventTest.php

7 lines

5 lines

IssueCommentEventTest.php

2 lines

PullRequestEventTest.php

2 lines

PushEventTest.php

6 lines

RepositoryEventTest.php

10 lines

StatusEventTest.php

2 lines

UnknownEventTest.php

2 lines

GitHubPayloadAnalyzerTest.php

14 lines

Jenkins/

JenkinsPayloadAnalyzerConfigurationTest.php

6 lines

JenkinsPayloadAnalyzerTest.php

5 lines

PayloadAnalyzerConfigurationTest.php

6 lines

Phabricator/

PhabricatorGroupMappingTest.php

2 lines

PhabricatorPayloadAnalyzerTest.php

8 lines

WithConfiguration.php

1 line

Config/

FeaturesTest.php

2 lines

Reporting/

FeatureReportEntryTest.php

6 lines

IntegrationTest.php

2 lines

ServiceReportEntryTest.php

3 lines

Services/

ServiceTest.php

2 lines

ServicesTest.php

2 lines

Console/

Commands/

ConfigShowTest.php

6 lines

ConfigValidateTest.php

4 lines

NotificationsPayloadTest.php

8 lines

PhabricatorProjectsMapTest.php

3 lines

12 lines

26 lines

Exceptions/

HandlerTest.php

8 lines

Facades/

DockerHubTest.php

6 lines

MailgunTest.php

7 lines

5 lines

Http/

Controllers/

GitHubGateControllerTest.php

2 lines

PayloadFullTest.php

2 lines

PlaceholderTest.php

7 lines

7 lines

Jobs/

NotifyNewCommitsToDiffusionTest.php

8 lines

Notifications/

DockerHubNotificationTest.php

6 lines

Phabricator/

PhabricatorAPIExceptionTest.php

2 lines

PhabricatorAPIFactoryTest.php

2 lines

PhabricatorAPITest.php

8 lines

ProjectsMapFactoryTest.php

2 lines

ProjectsMapTest.php

18 lines

Providers/

6 lines

DockerHubServiceProviderTest.php

3 lines

EventServiceProviderTest.php

24 lines

ServicesServiceProviderTest.php

2 lines

10 lines

Diff 6796

.arclint

Loading...

app/Analyzers/BasePayloadAnalyzer.php

Loading...

app/Analyzers/DockerHub/BuildFailureEvent.php

Loading...

app/Analyzers/GitHub/Events/Event.php

Loading...

app/Analyzers/GitHub/Events/IssueCommentEvent.php

Loading...

app/Analyzers/GitHub/Events/PullRequestEvent.php

Loading...

app/Analyzers/GitHub/Events/PushEvent.php

Loading...

app/Analyzers/GitHub/Events/WithRef.php

Loading...

app/Analyzers/GitHub/Events/WithRepoAndBranch.php

Loading...

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

Loading...

app/Analyzers/ItemGroupMapping.php

Loading...

app/Analyzers/Jenkins/JenkinsPayloadAnalyzer.php

Loading...

app/Config/Features.php

Loading...

app/Config/Reporting/BaseReportEntry.php

Loading...

app/Config/Reporting/ConfigReport.php

Loading...

app/Config/Reporting/ServiceReportEntry.php

Loading...

app/Config/Services/Services.php

Loading...

app/Console/Commands/ConfigValidate.php

Loading...

app/Console/Commands/NotificationsPayload.php

Loading...

app/Console/Commands/PhabricatorProjectsMap.php

Loading...

app/Contracts/APIClient.php

Loading...

app/Contracts/APIFactory.php

Loading...

app/Events/DockerHubPayloadEvent.php

Loading...

app/Events/GitHubPayloadEvent.php

Loading...

app/Events/JenkinsPayloadEvent.php

Loading...

app/Events/NotificationEvent.php

Loading...

app/Events/PhabricatorPayloadEvent.php

Loading...

app/Events/ReportEvent.php

Loading...

app/Exceptions/Handler.php

Loading...

app/Facades/Raven.php

Loading...

app/Http/Controllers/Controller.php

Loading...

app/Http/Controllers/Gate/DockerHubGateController.php

Loading...

app/Http/Controllers/Gate/GateController.php

Loading...

app/Http/Controllers/Gate/GitHubGateController.php

Loading...

app/Http/Controllers/Gate/JenkinsGateController.php

Loading...

app/Http/Controllers/Gate/NotificationGateController.php

Loading...

app/Http/Controllers/Gate/PhabricatorGateController.php

Loading...

app/Http/routes.php

Loading...

app/Jobs/FireDockerHubNotification.php

Loading...

app/Jobs/FireGitHubNotification.php

Loading...

app/Jobs/FireJenkinsNotification.php

Loading...

app/Jobs/FirePhabricatorNotification.php

Loading...

app/Jobs/NotifyNewCommitsToDiffusion.php

Loading...

app/Jobs/SendMessageToBroker.php

Loading...

app/Jobs/TriggerDockerHubBuild.php

Loading...

app/Listeners/AMQPEventListener.php

Loading...

app/Listeners/DockerHubListener.php

Loading...

app/Listeners/LastPayloadSaver.php

Loading...

app/Listeners/NotificationListener.php

Loading...

app/Listeners/PhabricatorListener.php

Loading...

app/Notifications/DockerHubNotification.php

Loading...

app/Phabricator/PhabricatorAPI.php

Loading...

app/Phabricator/PhabricatorStory.php

Loading...

app/Phabricator/ProjectsMap.php

Loading...

app/Phabricator/ProjectsMapFactory.php

Loading...

app/Providers/DockerHubServiceProvider.php

Loading...

app/Providers/EventServiceProvider.php

Loading...

app/Providers/MailgunServiceProvider.php

Loading...

app/Providers/PhabricatorAPIServiceProvider.php

Loading...

app/Providers/PhabricatorProjectsMapServiceProvider.php

Loading...

app/Providers/ReportServiceProvider.php

Loading...

app/Providers/RouteServiceProvider.php

Loading...

composer.json

Loading...

config/app.php

Loading...

phpcs.xml

Loading...

tests/Actions/AMQPActionTest.php

Loading...

tests/Actions/ActionErrorTest.php

Loading...

tests/Actions/ActionsReportTest.php

Loading...

tests/Actions/NotifyNewCommitsActionTest.php

Loading...

tests/Actions/TriggerDockerHubBuildActionTest.php

Loading...

tests/Analyzers/GitHub/Events/CreateEventTest.php

Loading...

tests/Analyzers/GitHub/Events/DeleteEventTest.php

Loading...

tests/Analyzers/GitHub/Events/EventTest.php

Loading...

tests/Analyzers/GitHub/Events/IssueCommentEventTest.php

Loading...

tests/Analyzers/GitHub/Events/PullRequestEventTest.php

Loading...

tests/Analyzers/GitHub/Events/PushEventTest.php

Loading...

tests/Analyzers/GitHub/Events/RepositoryEventTest.php

Loading...

tests/Analyzers/GitHub/Events/StatusEventTest.php

Loading...

tests/Analyzers/GitHub/Events/UnknownEventTest.php

Loading...

tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php

Loading...

tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfigurationTest.php

Loading...

tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerTest.php

Loading...

tests/Analyzers/PayloadAnalyzerConfigurationTest.php

Loading...

tests/Analyzers/Phabricator/PhabricatorGroupMappingTest.php

Loading...

tests/Analyzers/Phabricator/PhabricatorPayloadAnalyzerTest.php

Loading...

tests/Analyzers/Phabricator/WithConfiguration.php

Loading...

tests/Config/FeaturesTest.php

Loading...

tests/Config/Reporting/FeatureReportEntryTest.php

Loading...

tests/Config/Reporting/IntegrationTest.php

Loading...

tests/Config/Reporting/ServiceReportEntryTest.php

Loading...

tests/Config/Services/ServiceTest.php

Loading...

tests/Config/Services/ServicesTest.php

Loading...

tests/Console/Commands/ConfigShowTest.php

Loading...

tests/Console/Commands/ConfigValidateTest.php

Loading...

tests/Console/Commands/NotificationsPayloadTest.php

Loading...

tests/Console/Commands/PhabricatorProjectsMapTest.php

Loading...

tests/Console/Commands/TestCase.php

Loading...

tests/Console/KernelTest.php

Loading...

tests/Exceptions/HandlerTest.php

Loading...

tests/Facades/DockerHubTest.php

Loading...

tests/Facades/MailgunTest.php

Loading...

tests/Facades/RavenTest.php

Loading...

tests/Http/Controllers/GitHubGateControllerTest.php

Loading...

tests/Http/PayloadFullTest.php

Loading...

tests/Http/PlaceholderTest.php

Loading...

tests/Http/StatusTest.php

Loading...

tests/Jobs/NotifyNewCommitsToDiffusionTest.php

Loading...

tests/Notifications/DockerHubNotificationTest.php

Loading...

tests/Phabricator/PhabricatorAPIExceptionTest.php

Loading...

tests/Phabricator/PhabricatorAPIFactoryTest.php

Loading...

tests/Phabricator/PhabricatorAPITest.php

Loading...

tests/Phabricator/ProjectsMapFactoryTest.php

Loading...

tests/Phabricator/ProjectsMapTest.php

Loading...

tests/Providers/ConfigTest.php

Loading...

tests/Providers/DockerHubServiceProviderTest.php

Loading...

tests/Providers/EventServiceProviderTest.php

Loading...

tests/Providers/ServicesServiceProviderTest.php

Loading...

tests/TestCase.php

Loading...