Page MenuHomeDevCentral
Differential D2674

Update Laravel 8
ClosedPublic
Actions

Authored by DorianWinty on Apr 16 2022, 22:51.
Tags
  • Restricted Project
Referenced Files
F3772688: D2674.id6785.diff
Sun, Nov 24, 04:36
F3772671: D2674.id6800.diff
Sun, Nov 24, 04:33
Unknown Object (File)
Sat, Nov 23, 01:15
Unknown Object (File)
Fri, Nov 22, 21:19
Unknown Object (File)
Fri, Nov 22, 11:11
Unknown Object (File)
Fri, Nov 22, 05:31
Unknown Object (File)
Fri, Nov 22, 05:24
Unknown Object (File)
Fri, Nov 22, 05:02
View All Files
Subscribers
dereckson
Tokens
"Yellow Medal" token, awarded by dereckson.

Details

Reviewers
dereckson
Maniphest Tasks
T1725: Upgrade Laravel
Commits
rNOTIF327396a753b0: Update Laravel 8
Summary

Update to Laravel 8

Ref T1725

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Errors
SeverityLocationCodeMessage
Errortests/Analyzers/GitHub/Events/EventTest.php:58PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/EventTest.php:72PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/IssueCommentEventTest.php:38PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/IssueCommentEventTest.php:39PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PullRequestEventTest.php:38PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PullRequestEventTest.php:39PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PullRequestEventTest.php:41PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PushEventTest.php:42PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PushEventTest.php:57PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Analyzers/GitHub/Events/PushEventTest.php:58PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errortests/Http/PlaceholderTest.php:12PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errortests/Http/StatusTest.php:12PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Errortests/Providers/ConfigTest.php:38PHPCS.E.Generic.Strings.UnnecessaryStringConcat.FoundGeneric.Strings.UnnecessaryStringConcat.Found
Errortests/Providers/EventServiceProviderTest.php:34PHPCS.E.Generic.Strings.UnnecessaryStringConcat.FoundGeneric.Strings.UnnecessaryStringConcat.Found
Errortests/TestCase.php:27PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLineGeneric.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Warningapp/Providers/RouteServiceProvider.php:37PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass
Unit
Tests Passed
Branch
arcpatch-D2674

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Harbormaster completed remote builds in B4197: Diff 6758.Apr 18 2022, 17:39
DorianWinty updated this revision to Diff 6759.Apr 18 2022, 20:37

correct arc lint bug

Harbormaster completed remote builds in B4198: Diff 6759.Apr 18 2022, 20:37
DorianWinty added a project: Restricted Project.Apr 19 2022, 07:43
DorianWinty edited the summary of this revision. (Show Details)Apr 19 2022, 07:59
DorianWinty added a task: T1725: Upgrade Laravel.
DorianWinty updated this revision to Diff 6760.Apr 19 2022, 18:45

adding codestyle
adding on the up of file the class that is use
adding using str_ instead of str::

Harbormaster completed remote builds in B4199: Diff 6760.Apr 19 2022, 18:45
DorianWinty updated this revision to Diff 6763.Apr 19 2022, 20:09

wip

Harbormaster completed remote builds in B4200: Diff 6763.Apr 19 2022, 20:09
DorianWinty updated this revision to Diff 6766.Apr 19 2022, 22:29

removing last str::

Harbormaster completed remote builds in B4202: Diff 6766.Apr 19 2022, 22:29
dereckson added a subscriber: dereckson.Apr 20 2022, 08:44
dereckson added inline comments.
app/Actions/AMQPAction.php
34 ↗(On Diff #6766)

Not in the scope of the upgrade. Those esthetic changes are welcome, but:

  • it's the other way around, ie the PREVIOUS public function __construct ) was the correct one
  • it should be done in a separate change against main branch (we can merge esthetic changes before upgrade without any issue)
app/Actions/Action.php
20 ↗(On Diff #6766)

Probably created by a phpcbf with MediaWiki setting.

The previous code was correct.

33 ↗(On Diff #6766)

Same issue, previous file was fully correct in style.

DorianWinty updated this revision to Diff 6767.Apr 22 2022, 15:50

correction err

Harbormaster completed remote builds in B4203: Diff 6767.Apr 22 2022, 15:50
DorianWinty updated this revision to Diff 6768.Apr 22 2022, 22:10

correct tests
update some packages

Harbormaster completed remote builds in B4204: Diff 6768.Apr 22 2022, 22:10
DorianWinty updated this revision to Diff 6779.May 4 2022, 19:39

correcting some Tests

Harbormaster completed remote builds in B4214: Diff 6779.May 4 2022, 19:39
DorianWinty updated this revision to Diff 6781.May 7 2022, 19:24

correct to make work the tests

Harbormaster completed remote builds in B4215: Diff 6781.May 7 2022, 19:24
DorianWinty published this revision for review.May 7 2022, 19:31
DorianWinty retitled this revision from WIP Update Laravel 8 to Update Laravel 8.
DorianWinty updated this revision to Diff 6785.May 7 2022, 20:44

modify test
remove unused use

Harbormaster completed remote builds in B4217: Diff 6785.May 7 2022, 20:44
alken-orin added a comment.May 8 2022, 12:04

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/253/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/253/console

DorianWinty updated this revision to Diff 6790.May 8 2022, 14:52

adding back one removed file

alken-orin added a comment.May 8 2022, 14:52

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/254/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/254/console

Harbormaster failed remote builds in B4222: Diff 6790!May 8 2022, 14:52
dereckson mentioned this in D2683: Modernize build.xml.May 8 2022, 15:17
DorianWinty updated this revision to Diff 6796.May 8 2022, 17:00

rebased

alken-orin added a comment.May 8 2022, 17:01

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/256/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/256/console

Harbormaster failed remote builds in B4225: Diff 6796!May 8 2022, 17:01
dereckson requested changes to this revision.May 8 2022, 17:33
dereckson added inline comments.
app/Analyzers/GitHub/Events/Event.php
34

Extraneous added line

48

extraneous added line

app/Analyzers/GitHub/Events/IssueCommentEvent.php
20

MediaWiki style

app/Analyzers/GitHub/Events/PullRequestEvent.php
18

MediaWiki

tests/TestCase.php
5

Restore that division

  1. Our app
  2. External libs
  3. Global space
This revision now requires changes to proceed.May 8 2022, 17:33
alken-orin added a comment.May 8 2022, 18:31

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/257/ for more details.

DorianWinty retitled this revision from Update Laravel 8 to WIP Update Laravel 8.May 9 2022, 18:14
DorianWinty updated this revision to Diff 6799.May 9 2022, 18:30
DorianWinty marked 5 inline comments as done.

modify folowing comments but need more to reading

alken-orin added a comment.May 9 2022, 18:31

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/258/ for more details.

Harbormaster completed remote builds in B4228: Diff 6799.May 9 2022, 18:31
DorianWinty retitled this revision from WIP Update Laravel 8 to Update Laravel 8.May 9 2022, 18:31
DorianWinty updated this revision to Diff 6800.May 10 2022, 17:38

correcting style problem due to mediawiki phpcs style

alken-orin added a comment.May 10 2022, 17:38

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/259/ for more details.

Harbormaster completed remote builds in B4229: Diff 6800.May 10 2022, 17:38
DorianWinty updated this revision to Diff 6801.May 10 2022, 17:53

correcting MW style to old style

alken-orin added a comment.May 10 2022, 17:54

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/260/ for more details.

Harbormaster completed remote builds in B4230: Diff 6801.May 10 2022, 17:54
DorianWinty updated this revision to Diff 6802.May 10 2022, 18:05

phpcbf

alken-orin added a comment.May 10 2022, 18:05

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/261/ for more details.

Harbormaster completed remote builds in B4231: Diff 6802.May 10 2022, 18:05
dereckson requested changes to this revision.May 12 2022, 11:37
dereckson added inline comments.
app/Config/Reporting/BaseReportEntry.php
11–12

"public abstract" is more convenient as it's coherent with "public static":

That would mean an order <visibility> [special status] function <function name>.

More generally, run automated tools and accept ANY modification they do is a probably not a good idea, git add -p to filter the useful ones is very convenient with those "magic" tools.

app/Providers/RouteServiceProvider.php
36–37

MediaWiki style

composer.json
23–24

Two needs to be restored now we're up to date:

  • phploc
  • phpcpd
53

For phpmd, it's well ruleset.xml

tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php
68

MediaWiki style

tests/Analyzers/Phabricator/PhabricatorPayloadAnalyzerTest.php
90

MW

tests/Config/FeaturesTest.php
25

MW

tests/Console/Commands/NotificationsPayloadTest.php
49

MW (the two lines)

tests/Notifications/DockerHubNotificationTest.php
12

Extraneous line

This revision now requires changes to proceed.May 12 2022, 11:37
DorianWinty updated this revision to Diff 6806.May 13 2022, 06:53
DorianWinty marked 9 inline comments as done.

correction with the comments

alken-orin added a comment.May 13 2022, 06:54

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/262/ for more details.

Harbormaster completed remote builds in B4235: Diff 6806.May 13 2022, 06:54
dereckson accepted this revision.May 21 2022, 19:25
dereckson awarded a token.
This revision is now accepted and ready to land.May 21 2022, 19:25
This revision was landed with ongoing or failed builds.May 21 2022, 20:02
Closed by commit rNOTIF327396a753b0: Update Laravel 8 (authored by DorianWinty). · Explain Why
This revision was automatically updated to reflect the committed changes.
DorianWinty added a commit: rNOTIF327396a753b0: Update Laravel 8.
DorianWinty mentioned this in D2673: WIP Update Laravel 5.8.May 21 2022, 20:10

Revision Contents
Changeset List

PathSize
8 lines
app/
Analyzers/
9 lines
DockerHub/
2 lines
GitHub/
Events/
20 lines
3 lines
4 lines
2 lines
4 lines
2 lines
2 lines
4 lines
Jenkins/
2 lines
Config/
2 lines
Reporting/
4 lines
4 lines
2 lines
Services/
2 lines
Console/
Commands/
3 lines
1 line
4 lines
Contracts/
4 lines
2 lines
Events/
1 line
1 line
1 line
1 line
2 lines
2 lines
Exceptions/
18 lines
Facades/
3 lines
Http/
Controllers/
8 lines
Gate/
7 lines
13 lines
8 lines
7 lines
14 lines
7 lines
4 lines
Jobs/
9 lines
9 lines
9 lines
11 lines
9 lines
9 lines
7 lines
Listeners/
24 lines
25 lines
26 lines
40 lines
21 lines
Phabricator/
3 lines
2 lines
4 lines
4 lines
Providers/
5 lines
55 lines
6 lines
2 lines
2 lines
2 lines
10 lines
35 lines
config/
20 lines
8 lines
tests/
Actions/
4 lines
4 lines
12 lines
4 lines
4 lines
Analyzers/
GitHub/
Events/
8 lines
8 lines
6 lines
2 lines
2 lines
6 lines
10 lines
2 lines
2 lines
14 lines
Jenkins/
6 lines
5 lines
6 lines
Phabricator/
2 lines
8 lines
1 line
Config/
2 lines
Reporting/
2 lines
2 lines
3 lines
Services/
2 lines
2 lines
Console/
Commands/
4 lines
4 lines
8 lines
3 lines
9 lines
19 lines
Exceptions/
7 lines
Facades/
4 lines
4 lines
4 lines
Http/
Controllers/
2 lines
2 lines
7 lines
7 lines
Jobs/
6 lines
Notifications/
1 line
Phabricator/
2 lines
2 lines
8 lines
2 lines
17 lines
Providers/
6 lines
2 lines
24 lines
2 lines
9 lines

Diff 6800

View Options

.arclint

Loading...
View Options

app/Analyzers/BasePayloadAnalyzer.php

Loading...
View Options

app/Analyzers/DockerHub/BuildFailureEvent.php

Loading...
View Options

app/Analyzers/GitHub/Events/Event.php

Loading...
View Options

app/Analyzers/GitHub/Events/IssueCommentEvent.php

Loading...
View Options

app/Analyzers/GitHub/Events/PullRequestEvent.php

Loading...
View Options

app/Analyzers/GitHub/Events/PushEvent.php

Loading...
View Options

app/Analyzers/GitHub/Events/WithRef.php

Loading...
View Options

app/Analyzers/GitHub/Events/WithRepoAndBranch.php

Loading...
View Options

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

Loading...
View Options

app/Analyzers/ItemGroupMapping.php

Loading...
View Options

app/Analyzers/Jenkins/JenkinsPayloadAnalyzer.php

Loading...
View Options

app/Config/Features.php

Loading...
View Options

app/Config/Reporting/BaseReportEntry.php

Loading...
View Options

app/Config/Reporting/ConfigReport.php

Loading...
View Options

app/Config/Reporting/ServiceReportEntry.php

Loading...
View Options

app/Config/Services/Services.php

Loading...
View Options

app/Console/Commands/ConfigValidate.php

Loading...
View Options

app/Console/Commands/NotificationsPayload.php

Loading...
View Options

app/Console/Commands/PhabricatorProjectsMap.php

Loading...
View Options

app/Contracts/APIClient.php

Loading...
View Options

app/Contracts/APIFactory.php

Loading...
View Options

app/Events/DockerHubPayloadEvent.php

Loading...
View Options

app/Events/GitHubPayloadEvent.php

Loading...
View Options

app/Events/JenkinsPayloadEvent.php

Loading...
View Options

app/Events/NotificationEvent.php

Loading...
View Options

app/Events/PhabricatorPayloadEvent.php

Loading...
View Options

app/Events/ReportEvent.php

Loading...
View Options

app/Exceptions/Handler.php

Loading...
View Options

app/Facades/Raven.php

Loading...
View Options

app/Http/Controllers/Controller.php

Loading...
View Options

app/Http/Controllers/Gate/DockerHubGateController.php

Loading...
View Options

app/Http/Controllers/Gate/GateController.php

Loading...
View Options

app/Http/Controllers/Gate/GitHubGateController.php

Loading...
View Options

app/Http/Controllers/Gate/JenkinsGateController.php

Loading...
View Options

app/Http/Controllers/Gate/NotificationGateController.php

Loading...
View Options

app/Http/Controllers/Gate/PhabricatorGateController.php

Loading...
View Options

app/Http/routes.php

Loading...
View Options

app/Jobs/FireDockerHubNotification.php

Loading...
View Options

app/Jobs/FireGitHubNotification.php

Loading...
View Options

app/Jobs/FireJenkinsNotification.php

Loading...
View Options

app/Jobs/FirePhabricatorNotification.php

Loading...
View Options

app/Jobs/NotifyNewCommitsToDiffusion.php

Loading...
View Options

app/Jobs/SendMessageToBroker.php

Loading...
View Options

app/Jobs/TriggerDockerHubBuild.php

Loading...
View Options

app/Listeners/AMQPEventListener.php

Loading...
View Options

app/Listeners/DockerHubListener.php

Loading...
View Options

app/Listeners/LastPayloadSaver.php

Loading...
View Options

app/Listeners/NotificationListener.php

Loading...
View Options

app/Listeners/PhabricatorListener.php

Loading...
View Options

app/Phabricator/PhabricatorAPI.php

Loading...
View Options

app/Phabricator/PhabricatorStory.php

Loading...
View Options

app/Phabricator/ProjectsMap.php

Loading...
View Options

app/Phabricator/ProjectsMapFactory.php

Loading...
View Options

app/Providers/DockerHubServiceProvider.php

Loading...
View Options

app/Providers/EventServiceProvider.php

Loading...
View Options

app/Providers/MailgunServiceProvider.php

Loading...
View Options

app/Providers/PhabricatorAPIServiceProvider.php

Loading...
View Options

app/Providers/PhabricatorProjectsMapServiceProvider.php

Loading...
View Options

app/Providers/ReportServiceProvider.php

Loading...
View Options

app/Providers/RouteServiceProvider.php

Loading...
View Options

composer.json

Loading...
View Options

config/app.php

Loading...
View Options

phpcs.xml

Loading...
View Options

tests/Actions/AMQPActionTest.php

Loading...
View Options

tests/Actions/ActionErrorTest.php

Loading...
View Options

tests/Actions/ActionsReportTest.php

Loading...
View Options

tests/Actions/NotifyNewCommitsActionTest.php

Loading...
View Options

tests/Actions/TriggerDockerHubBuildActionTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/CreateEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/DeleteEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/EventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/IssueCommentEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/PullRequestEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/PushEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/RepositoryEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/StatusEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/UnknownEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php

Loading...
View Options

tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfigurationTest.php

Loading...
View Options

tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerTest.php

Loading...
View Options

tests/Analyzers/PayloadAnalyzerConfigurationTest.php

Loading...
View Options

tests/Analyzers/Phabricator/PhabricatorGroupMappingTest.php

Loading...
View Options

tests/Analyzers/Phabricator/PhabricatorPayloadAnalyzerTest.php

Loading...
View Options

tests/Analyzers/Phabricator/WithConfiguration.php

Loading...
View Options

tests/Config/FeaturesTest.php

Loading...
View Options

tests/Config/Reporting/FeatureReportEntryTest.php

Loading...
View Options

tests/Config/Reporting/IntegrationTest.php

Loading...
View Options

tests/Config/Reporting/ServiceReportEntryTest.php

Loading...
View Options

tests/Config/Services/ServiceTest.php

Loading...
View Options

tests/Config/Services/ServicesTest.php

Loading...
View Options

tests/Console/Commands/ConfigShowTest.php

Loading...
View Options

tests/Console/Commands/ConfigValidateTest.php

Loading...
View Options

tests/Console/Commands/NotificationsPayloadTest.php

Loading...
View Options

tests/Console/Commands/PhabricatorProjectsMapTest.php

Loading...
View Options

tests/Console/Commands/TestCase.php

Loading...
View Options

tests/Console/KernelTest.php

Loading...
View Options

tests/Exceptions/HandlerTest.php

Loading...
View Options

tests/Facades/DockerHubTest.php

Loading...
View Options

tests/Facades/MailgunTest.php

Loading...
View Options

tests/Facades/RavenTest.php

Loading...
View Options

tests/Http/Controllers/GitHubGateControllerTest.php

Loading...
View Options

tests/Http/PayloadFullTest.php

Loading...
View Options

tests/Http/PlaceholderTest.php

Loading...
View Options

tests/Http/StatusTest.php

Loading...
View Options

tests/Jobs/NotifyNewCommitsToDiffusionTest.php

Loading...
View Options

tests/Notifications/DockerHubNotificationTest.php

Loading...
View Options

tests/Phabricator/PhabricatorAPIExceptionTest.php

Loading...
View Options

tests/Phabricator/PhabricatorAPIFactoryTest.php

Loading...
View Options

tests/Phabricator/PhabricatorAPITest.php

Loading...
View Options

tests/Phabricator/ProjectsMapFactoryTest.php

Loading...
View Options

tests/Phabricator/ProjectsMapTest.php

Loading...
View Options

tests/Providers/ConfigTest.php

Loading...
View Options

tests/Providers/DockerHubServiceProviderTest.php

Loading...
View Options

tests/Providers/EventServiceProviderTest.php

Loading...
View Options

tests/Providers/ServicesServiceProviderTest.php

Loading...
View Options

tests/TestCase.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator