Update to Laravel 8
Ref T1725
Details
Details
- Reviewers
dereckson - Maniphest Tasks
- T1725: Upgrade Laravel
- Commits
- rNOTIF327396a753b0: Update Laravel 8
Diff Detail
Diff Detail
- Repository
- rNOTIF Notifications center
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
adding codestyle
adding on the up of file the class that is use
adding using str_ instead of str::
| app/Actions/AMQPAction.php | ||
|---|---|---|
| 34 ↗ | (On Diff #6766) | Not in the scope of the upgrade. Those esthetic changes are welcome, but:
|
| app/Actions/Action.php | ||
| 20 ↗ | (On Diff #6766) | Probably created by a phpcbf with MediaWiki setting. The previous code was correct. |
| 33 ↗ | (On Diff #6766) | Same issue, previous file was fully correct in style. |
Comment Actions
Build has FAILED
Link to build: https://ci.nasqueron.org/job/test-notifications-phab/253/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/253/console
Comment Actions
Build has FAILED
Link to build: https://ci.nasqueron.org/job/test-notifications-phab/254/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/254/console
Comment Actions
Build has FAILED
Link to build: https://ci.nasqueron.org/job/test-notifications-phab/256/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/256/console
Comment Actions
Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/257/ for more details.
Comment Actions
Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/258/ for more details.
Comment Actions
Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/259/ for more details.
Comment Actions
Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/260/ for more details.
Comment Actions
Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/261/ for more details.
| app/Config/Reporting/BaseReportEntry.php | ||
|---|---|---|
| 11 ↗ | (On Diff #6802) | "public abstract" is more convenient as it's coherent with "public static": That would mean an order <visibility> [special status] function <function name>. More generally, run automated tools and accept ANY modification they do is a probably not a good idea, git add -p to filter the useful ones is very convenient with those "magic" tools. |
| app/Providers/RouteServiceProvider.php | ||
| 37 | MediaWiki style | |
| composer.json | ||
| 23–24 | Two needs to be restored now we're up to date:
| |
| 55 | For phpmd, it's well ruleset.xml | |
| tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php | ||
| 68 | MediaWiki style | |
| tests/Analyzers/Phabricator/PhabricatorPayloadAnalyzerTest.php | ||
| 90 | MW | |
| tests/Config/FeaturesTest.php | ||
| 25 | MW | |
| tests/Console/Commands/NotificationsPayloadTest.php | ||
| 51 | MW (the two lines) | |
| tests/Notifications/DockerHubNotificationTest.php | ||
| 12 ↗ | (On Diff #6802) | Extraneous line |
Comment Actions
Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/262/ for more details.