Some parameters are missing for the declaration of functions.
Details
Details
Diff Detail
Diff Detail
- Repository
- rNOTIF Notifications center
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/264/ for more details.
Comment Actions
Same issues for files below.
app/Analyzers/DockerHub/BaseEvent.php | ||
---|---|---|
17 | OK, but a better type will be available with T1076. | |
app/Analyzers/GitHub/Events/RepositoryEvent.php | ||
16 | No whiteline is needed between params and return value. | |
18 | ||
app/Analyzers/GitHub/Events/WithCommit.php | ||
25 | Not needed whiteline. | |
27 | Let's also define return types. | |
app/Phabricator/PhabricatorAPI.php | ||
82 | ||
118 | - | |
app/Phabricator/PhabricatorAPIFactory.php | ||
13 | - | |
15 | ||
23 | - | |
25 |
Comment Actions
Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/265/ for more details.
Comment Actions
Per discussion on Whatsapp, Dorian intends to add return types in a second commit.
(not that we should discuss open source software development in a private system like WhatsApp, but we were discussing there when the issue was raised)