Page MenuHomeDevCentral

Add the missing parameter's type declaration of each functions
ClosedPublic

Authored by DorianWinty on May 22 2022, 15:44.

Details

Summary

Some parameters are missing for the declaration of functions.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested changes to this revision.May 26 2022, 21:08

Same issues for files below.

app/Analyzers/DockerHub/BaseEvent.php
17

OK, but a better type will be available with T1076.

app/Analyzers/GitHub/Events/RepositoryEvent.php
16

No whiteline is needed between params and return value.

18
app/Analyzers/GitHub/Events/WithCommit.php
25

Not needed whiteline.

27

Let's also define return types.

app/Phabricator/PhabricatorAPI.php
82
118

-

app/Phabricator/PhabricatorAPIFactory.php
13

-

15
23

-

25
This revision now requires changes to proceed.May 26 2022, 21:08
DorianWinty marked 11 inline comments as done.

modify folowing comment

This revision is now accepted and ready to land.May 27 2022, 20:16

Per discussion on Whatsapp, Dorian intends to add return types in a second commit.

(not that we should discuss open source software development in a private system like WhatsApp, but we were discussing there when the issue was raised)