Differential D2692

Add the missing parameter's type declaration of each functions
ClosedPublic
Actions

Authored by DorianWinty on May 22 2022, 15:44.

Tags

None

Referenced Files

	F3766127: D2692.diff
	Fri, Nov 22, 16:35

	F3763974: D2692.id6819.diff
	Fri, Nov 22, 03:38

	Unknown Object (File)
	Mon, Nov 18, 11:46

	Unknown Object (File)
	Sat, Nov 16, 05:47

	Unknown Object (File)
	Thu, Nov 14, 20:29

	Unknown Object (File)
	Tue, Nov 12, 10:35

	Unknown Object (File)
	Tue, Nov 12, 07:47

	Unknown Object (File)
	Tue, Nov 12, 04:54

Subscribers

Details

Reviewers

Commits

rNOTIF6995b71ffd0c: Add the missing parameter's type declaration of each functions

Summary

Some parameters are missing for the declaration of functions.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

useNames

Event Timeline

DorianWinty created this revision.May 22 2022, 15:44

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/264/ for more details.

Harbormaster completed remote builds in B4241: Diff 6819.May 22 2022, 15:45

DorianWinty requested review of this revision.May 22 2022, 15:45

DorianWinty added a reviewer: dereckson.May 22 2022, 15:45

Same issues for files below.

app/Analyzers/DockerHub/BaseEvent.php
17	OK, but a better type will be available with T1076.
app/Analyzers/GitHub/Events/RepositoryEvent.php
16	No whiteline is needed between params and return value.
19
app/Analyzers/GitHub/Events/WithCommit.php
26	Not needed whiteline.
29	Let's also define return types.
app/Phabricator/PhabricatorAPI.php
82
118	-
app/Phabricator/PhabricatorAPIFactory.php
13	-
16
24	-
27

This revision now requires changes to proceed.May 26 2022, 21:08

modify folowing comment

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/265/ for more details.

Harbormaster completed remote builds in B4264: Diff 6855.May 27 2022, 20:12

dereckson accepted this revision.May 27 2022, 20:16

This revision is now accepted and ready to land.May 27 2022, 20:16

Per discussion on Whatsapp, Dorian intends to add return types in a second commit.

(not that we should discuss open source software development in a private system like WhatsApp, but we were discussing there when the issue was raised)

Closed by commit rNOTIF6995b71ffd0c: Add the missing parameter's type declaration of each functions (authored by DorianWinty). · Explain WhyMay 27 2022, 20:22

This revision was automatically updated to reflect the committed changes.

DorianWinty added a commit: rNOTIF6995b71ffd0c: Add the missing parameter's type declaration of each functions.

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

DockerHub/

2 lines

BuildFailureEvent.php

2 lines

GitHub/

Events/

RepositoryEvent.php

3 lines

3 lines

Config/

Services/

2 lines

Events/

DockerHubPayloadEvent.php

4 lines

GitHubPayloadEvent.php

6 lines

JenkinsPayloadEvent.php

4 lines

Listeners/

LastPayloadSaver.php

2 lines

Notifications/

JenkinsNotification.php

4 lines

Phabricator/

PhabricatorAPI.php

14 lines

PhabricatorAPIFactory.php

6 lines

PhabricatorStory.php

13 lines

ProjectsMap.php

16 lines

Diff 6819

app/Analyzers/DockerHub/BaseEvent.php

Loading...

app/Analyzers/DockerHub/BuildFailureEvent.php

Loading...

app/Analyzers/GitHub/Events/RepositoryEvent.php

Loading...

app/Analyzers/GitHub/Events/WithCommit.php

Loading...

app/Config/Services/Services.php

Loading...

app/Events/DockerHubPayloadEvent.php

Loading...

app/Events/GitHubPayloadEvent.php

Loading...

app/Events/JenkinsPayloadEvent.php

Loading...

app/Listeners/LastPayloadSaver.php

Loading...

app/Notifications/JenkinsNotification.php

Loading...

app/Phabricator/PhabricatorAPI.php

Loading...

app/Phabricator/PhabricatorAPIFactory.php

Loading...

app/Phabricator/PhabricatorStory.php

Loading...

app/Phabricator/ProjectsMap.php

Loading...