Differential D2933

Fix PhabricatorAPI::getFirstResult signature
ClosedPublic
Actions

Authored by dereckson on Mar 27 2023, 22:20.

Details

Reviewers

dereckson

Commits

rNOTIF0b2e7fc8a33a: Fix PhabricatorAPI::getFirstResult signature

Summary

This is a follow-up for 6995b71ffd0c.

Test Plan

Fixed in production

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

main

Event Timeline

dereckson created this revision.Mar 27 2023, 22:20

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/276/ for more details.

Harbormaster completed remote builds in B4626: Diff 7469.Mar 27 2023, 22:22

dereckson requested review of this revision.Mar 27 2023, 22:22

Tests probably needed for that one.

Add tests (excepted for the objects without 'data' property, out of scope for this change)

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/277/ for more details.

Harbormaster completed remote builds in B4627: Diff 7470.Mar 27 2023, 22:56

dereckson accepted this revision.Mar 27 2023, 22:58

This revision is now accepted and ready to land.Mar 27 2023, 22:58

Closed by commit rNOTIF0b2e7fc8a33a: Fix PhabricatorAPI::getFirstResult signature (authored by dereckson). · Explain WhyMar 27 2023, 22:58

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rNOTIF0b2e7fc8a33a: Fix PhabricatorAPI::getFirstResult signature.

Self-commit as this fixes production issue and @DorianWinty is sleeping. This change has been tested in prod, and has tests for it.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorAPI.php

2 lines

tests/

Phabricator/

PhabricatorAPITest.php

14 lines

Diff 7470

View Options

app/Phabricator/PhabricatorAPI.php