Page MenuHomeDevCentral
Differential D3014

Log correctly stdout and stderr
ClosedPublic
Actions

Authored by dereckson on Apr 14 2023, 20:56.
Tags
None
Referenced Files
F3631560: D3014.diff
Sun, Oct 6, 16:30
Unknown Object (File)
Fri, Oct 4, 16:37
Unknown Object (File)
Mon, Sep 30, 18:05
Unknown Object (File)
Mon, Sep 30, 18:05
Unknown Object (File)
Mon, Sep 30, 18:05
Unknown Object (File)
Mon, Sep 30, 04:48
Unknown Object (File)
Sat, Sep 28, 08:53
Unknown Object (File)
Mon, Sep 23, 19:39
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rALK9e3423554678: Log correctly stdout and stderr
Summary

Stdio::piped() isn't necessary to capture the output of a process.

Also, a typo in the implementation confused stdout and stderr.

Test Plan
  • alkane serve, /init and /update
  • alkane deploy

Diff Detail

Repository
rALK Alkane
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
fix-stdout-stderr
Build Status
Buildable 4763
Build 5044: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 14 2023, 20:56
dereckson created this revision.
Harbormaster completed remote builds in B4763: Diff 7692.Apr 14 2023, 20:56
dereckson updated this revision to Diff 7693.Apr 14 2023, 20:56

Don't bump version I've seen another issue

Harbormaster completed remote builds in B4764: Diff 7693.Apr 14 2023, 20:56
dereckson accepted this revision.Apr 14 2023, 21:09
This revision is now accepted and ready to land.Apr 14 2023, 21:09
Closed by commit rALK9e3423554678: Log correctly stdout and stderr (authored by dereckson). · Explain WhyApr 14 2023, 21:11
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rALK9e3423554678: Log correctly stdout and stderr.

Revision Contents
Changeset List

PathSize
2 lines
src/
runner/
8 lines

Diff 7692

View Options

Cargo.toml

Loading...
View Options

src/runner/mod.rs

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator