Don't declare mutable variables as static
ClosedPublic
Actions

Authored by dereckson on May 15 2023, 16:37.

Tags

None

Referenced Files

	F3764166: D3095.diff
	Fri, Nov 22, 04:27

	Unknown Object (File)
	Wed, Nov 20, 19:53

	Unknown Object (File)
	Wed, Nov 20, 19:24

	Unknown Object (File)
	Tue, Nov 12, 12:43

	Unknown Object (File)
	Thu, Nov 7, 22:11

	Unknown Object (File)
	Thu, Nov 7, 11:17

	Unknown Object (File)
	Tue, Nov 5, 06:38

	Unknown Object (File)
	Tue, Nov 5, 04:32

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1870: Can't end network registration on Freenode

Commits

rDARKBOT829d0e0bda75: Don't declare mutable variables as static

Summary

This is a follow-up for 3633321609ab.

Fixes T1870.

Test Plan

Tested with Odderon on Libera

Diff Detail

Repository

rDARKBOT Darkbot

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-static

Build Status

Buildable 4887
Build 5168: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.May 15 2023, 16:37

dereckson created this revision.

Harbormaster completed remote builds in B4887: Diff 7900.May 15 2023, 16:37

Remove setup.ini SASL change, not in scope of this

Harbormaster completed remote builds in B4888: Diff 7901.May 15 2023, 16:40

Where we see why global variables are evil.

This revision is now accepted and ready to land.May 15 2023, 16:42

Closed by commit rDARKBOT829d0e0bda75: Don't declare mutable variables as static (authored by dereckson). · Explain WhyMay 15 2023, 16:42

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rDARKBOT829d0e0bda75: Don't declare mutable variables as static.

Revision Contents
Changeset List

Path

Size

dat/

setup.ini

2 lines

source/

vars.h

7 lines

Diff 7900

View Options

dat/setup.ini