Page MenuHomeDevCentral
Differential D3233

Provide simple PSR-16 cache implementation from configuration
ClosedPublic
Actions

Authored by dereckson on Jul 4 2023, 21:18.
Tags
None
Referenced Files
F3304361: D3233.diff
Wed, Jul 3, 08:34
Unknown Object (File)
Sat, Jun 29, 19:53
Unknown Object (File)
Sat, Jun 29, 15:10
Unknown Object (File)
Sat, Jun 29, 03:13
Unknown Object (File)
Sat, Jun 29, 01:52
Unknown Object (File)
Thu, Jun 27, 04:03
Unknown Object (File)
Wed, Jun 26, 15:08
Unknown Object (File)
Wed, Jun 26, 12:58
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1707: Import cache from Zed
Commits
rKC9001399da665: Provide simple PSR-16 cache implementation from configuration
rKERUALD72af498e7739: Provide simple PSR-16 cache implementation from configuration
Summary

Cache with basic get/set/has/delete/clear operations.
Abstraction layer for Memcached, Redis and a void mock-purpose.

Similar to the database package, read a configuration array
to build and load a concrete cache implementation.

This library is a PSR-16 implementation.
This library does NOT currently support PSR-6.

This library is intended to replace the Zed Cache engine,
and is based on the includes/cache classes from Zed code.

Test Plan

Full units test coverage

Diff Detail

Repository
rKERUALD Keruald libraries development repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcache/composer.json:17JSON1Parse Error
Errorcache/src/CacheFactory.php:38PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorcache/src/Engines/CacheMemcached.php:54PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorcache/src/Engines/CacheMemcached.php:56PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorcache/src/Engines/CacheRedis.php:41PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Errorcache/src/Engines/CacheRedis.php:152PHPCS.E.Generic.NamingConventions.CamelCapsFunctionName.ScopeNotCamelCapsGeneric.NamingConventions.CamelCapsFunctionName.ScopeNotCamelCaps
Errorcache/src/Engines/CacheRedis.php:152PHPCS.E.PSR1.Methods.CamelCapsMethodName.NotCamelCapsPSR1.Methods.CamelCapsMethodName.NotCamelCaps
Warningcache/src/Engines/CacheMemcached.php:99PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsedGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsed
Warningcache/src/Engines/CacheMemcached.php:156PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassBeforeLastUsedGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassBeforeLastUsed
Warningcache/src/Engines/CacheRedis.php:57PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warningcache/src/Engines/CacheVoid.php:21PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass
Warningcache/src/Engines/CacheVoid.php:25PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassBeforeLastUsedGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassBeforeLastUsed
Warningcache/src/Engines/CacheVoid.php:29PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsedGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsed
Warningcache/src/Engines/CacheVoid.php:29PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsedGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsed
Warningcache/src/Engines/CacheVoid.php:29PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsedGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsed
Warningcache/src/Engines/CacheVoid.php:37PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass
Warningcache/src/Engines/CacheVoid.php:45PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass
Warningcache/src/Engines/CacheVoid.php:58PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsedGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsed
Warningcache/src/Engines/CacheVoid.php:58PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsedGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsed
Warningcache/src/Engines/CacheVoid.php:65PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassGeneric.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass
Warningcache/src/Exceptions/CacheException.php:9PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warningcache/src/Features/WithPrefix.php:44PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
Test Failures
Branch
cache
Build Status
Buildable 5098
Build 5379: arc lint + arc unit

Unit TestsBroken
View All

TimeTest
0 msKeruald\Cache\Tests\Engines\CacheMemcachedTest
Keruald\Cache\Tests\Engines\CacheMemcachedTest::testSet Error: Class "Keruald\OmniTools\Network\SocketAddress" not found
0 msKeruald\Cache\Tests\Engines\CacheRedisTest
Keruald\Cache\Tests\Engines\CacheRedisTest::testSet Error: Class "Keruald\OmniTools\Network\SocketAddress" not found
3 msKeruald\Cache\Tests\CacheFactoryTest
4 msKeruald\Cache\Tests\Engines\CacheVoidTest

Event Timeline

dereckson requested review of this revision.Jul 4 2023, 21:18
dereckson created this revision.
Harbormaster completed remote builds in B5098: Diff 8301.Jul 4 2023, 21:18
dereckson updated this revision to Diff 8302.Jul 4 2023, 21:19

Rebased

Harbormaster completed remote builds in B5099: Diff 8302.Jul 4 2023, 21:19
dereckson accepted this revision.Jul 4 2023, 21:21
This revision is now accepted and ready to land.Jul 4 2023, 21:21
dereckson updated this revision to Diff 8303.Jul 4 2023, 21:21

Fix composer.json syntax

Harbormaster completed remote builds in B5100: Diff 8303.Jul 4 2023, 21:21
dereckson updated this revision to Diff 8304.Jul 4 2023, 21:21

Recheck tests

Harbormaster completed remote builds in B5101: Diff 8304.Jul 4 2023, 21:21
dereckson accepted this revision.Jul 4 2023, 21:22
dereckson edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jul 4 2023, 21:24
Closed by commit rKERUALD72af498e7739: Provide simple PSR-16 cache implementation from configuration (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rKERUALD72af498e7739: Provide simple PSR-16 cache implementation from configuration.
dereckson added a commit: rKC9001399da665: Provide simple PSR-16 cache implementation from configuration.Jul 4 2023, 21:29
dereckson added a task: T1707: Import cache from Zed.Jul 4 2023, 21:32

Revision Contents
Changeset List

PathSize
_utils/
templates/
8 lines
cache/
23 lines
42 lines
29 lines
src/
49 lines
44 lines
Engines/
161 lines
163 lines
69 lines
Exceptions/
11 lines
Features/
58 lines
tests/
9 lines
37 lines
Engines/
102 lines
102 lines
78 lines
13 lines
2 lines

Diff 8301

View Options

_utils/templates/generate-compose-json.php

Loading...
View Options

cache/LICENSE

Loading...
View Options

cache/README.md

Loading...
View Options

cache/composer.json

Loading...
View Options

cache/src/Cache.php

Loading...
View Options

cache/src/CacheFactory.php

Loading...
View Options

cache/src/Engines/CacheMemcached.php

Loading...
View Options

cache/src/Engines/CacheRedis.php

Loading...
View Options

cache/src/Engines/CacheVoid.php

Loading...
View Options

cache/src/Exceptions/CacheException.php

Loading...
View Options

cache/src/Features/WithPrefix.php

Loading...
View Options

cache/tests/CacheDummy.php

Loading...
View Options

cache/tests/CacheFactoryTest.php

Loading...
View Options

cache/tests/Engines/CacheMemcachedTest.php

Loading...
View Options

cache/tests/Engines/CacheRedisTest.php

Loading...
View Options

cache/tests/Engines/CacheVoidTest.php

Loading...
View Options

composer.json

Loading...
View Options

metadata.yml

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator