Page MenuHomeDevCentral
Differential D3632

Provision error logs by service and instance on PaaS Docker
Needs ReviewPublic
Actions

Authored by dereckson on Apr 5 2025, 14:06.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 1, 20:27
Unknown Object (File)
Wed, Oct 1, 12:41
Unknown Object (File)
Tue, Sep 30, 02:47
Unknown Object (File)
Tue, Sep 30, 02:44
Unknown Object (File)
Sun, Sep 28, 13:32
Unknown Object (File)
Sun, Sep 28, 13:32
Unknown Object (File)
Sun, Sep 28, 13:32
Unknown Object (File)
Sun, Sep 28, 13:32
View All Files
Subscribers
None

Details

Reviewers
DorianWinty
Summary

Currently, logs are unified into a single log file.

If that eases push to ElasticSearch / OpenSearch,
it doesn't offer a comfortable reading with grep/tail/etc.

The new structure will store log files in:

  • /var/log/www/<service>/<instance>-error.log
  • /var/log/www/<service>/<instance>-access.log

For a service, for example Phabricator, all the containers
have their web logs in the same place, to ease grep search.

Test Plan

Deploy on Dwellers

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
nginx-missing-directories
Build Status
Buildable 5801
Build 6083: arc lint + arc unit

Event Timeline

dereckson created this revision.Apr 5 2025, 14:06
dereckson held this revision as a draft.
Harbormaster completed remote builds in B5801: Diff 9395.Apr 5 2025, 14:06
dereckson updated this revision to Diff 9478.Thu, Sep 11, 19:18

Use /var/log/www/<service>/ folder for logs in vhosts

Harbormaster completed remote builds in B5860: Diff 9478.Thu, Sep 11, 19:18
dereckson published this revision for review.Thu, Sep 11, 19:27
dereckson retitled this revision from WIP: provision error logs by instance to Provision error logs by service and instance on PaaS Docker.
dereckson edited the summary of this revision. (Show Details)
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: DorianWinty.
dereckson planned changes to this revision.Thu, Sep 11, 20:23
dereckson added inline comments.
roles/paas-docker/nginx/config.sls
33–39

Could be interesting to filter them if host is defined,
as that's a hint nginx configuration is needed.

That would avoid this:

      ID: /var/log/www/mysql
Function: file.directory
  Result: True
 Comment:
 Started: 20:17:28.783079
Duration: 1.267 ms
 Changes:
          ----------
          /var/log/www/mysql:
              ----------
              directory:
                  new
dereckson updated this revision to Diff 9485.Thu, Sep 11, 23:25

Rebased. Don't create log directory for non-web services.

Harbormaster completed remote builds in B5865: Diff 9485.Thu, Sep 11, 23:25
dereckson updated this revision to Diff 9489.Fri, Sep 12, 17:22

Test paas_docker.is_nginx_service

Harbormaster completed remote builds in B5869: Diff 9489.Fri, Sep 12, 17:22
dereckson updated this revision to Diff 9490.Fri, Sep 12, 17:25

Use correct symbols in tests

Harbormaster completed remote builds in B5870: Diff 9490.Fri, Sep 12, 17:25

Revision Contents
Changeset List

PathSize
roles/
paas-docker/
nginx/
8 lines

Diff 9395

View Options

roles/paas-docker/nginx/config.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator