Page MenuHomeDevCentral

Fix node.resolve_network tests
ClosedPublic

Authored by dereckson on Sep 12 2025, 17:14.
Tags
None
Referenced Files
F12334183: D3663.id9721.diff
Sat, Oct 25, 14:17
Unknown Object (File)
Wed, Oct 22, 15:47
Unknown Object (File)
Sat, Oct 18, 23:18
Unknown Object (File)
Sat, Oct 18, 19:59
Unknown Object (File)
Sat, Oct 18, 09:21
Unknown Object (File)
Fri, Oct 17, 09:22
Unknown Object (File)
Thu, Oct 16, 15:34
Unknown Object (File)
Wed, Oct 15, 15:00
Subscribers
None

Details

Summary

Any private IP addressi instead of Drake network is ignored
by the node.resolve_network function, so we need to update
the private address in test data to belong to that range.

Furthermore, new entries have been added to the dictionary,
not handled by current test suite, so it makes more sense
to test for an exact subset than for equality.

This is a follow-up for 5877d5111f9a.
This is a follow-up for 4d08af81970d.

Ref T2123

Test Plan

(cd _tests && python3 -m unittest modules/test_node.py)

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Mon, Oct 13, 14:42
This revision was automatically updated to reflect the committed changes.