Page MenuHomeDevCentral
Create Task
Maniphest T2123

Fix tests for operations repository
Open, HighPublic
Actions

Description

Tests suite for rOPS needs some love to handle recent changes in _modules/ code.

If we use git bisect to a specific test, we can detect breakages and address them.

Revisions and Commits

rOPS Nasqueron Operations
Needs ReviewD3685 Avoid importlib.machinery.SourceFileLoader load_module use
Needs ReviewD3665 Prune unused webserver-content index generator
Needs ReviewD3664 Deploy the monitoring Vault policy
Needs ReviewD3663 Fix node.resolve_network tests
Needs ReviewD3662 Read flatter docker_networks pillar
Needs ReviewD3661 Avoid unittest deprecated aliases
Needs ReviewD3660 Fix docker_containers app_port/host test
Needs ReviewD3659 Handle ssh_keys_by_forest and everywhere_tasks in pillar users test

Related Objects

Event Timeline

dereckson triaged this task as High priority.EditedThu, Sep 11, 22:15
dereckson created this task.
dereckson added a subscriber: DorianWinty.

Going to take this, as I wrote the tests suite, @DorianWinty will review, so at least two of us will be familiar with the tests.

dereckson added a revision: D3659: Handle ssh_keys_by_forest and everywhere_tasks in pillar users test.EditedThu, Sep 11, 22:16

Tests fix commits will be aggregated in datacube T2123-improve-tests-suite branch, so we can have a look of what's remaining to fix.

dereckson added a revision: D3660: Fix docker_containers app_port/host test.Thu, Sep 11, 22:58
dereckson added a revision: D3661: Avoid unittest deprecated aliases.Thu, Sep 11, 23:09
dereckson added a revision: D3662: Read flatter docker_networks pillar.Thu, Sep 11, 23:56
dereckson mentioned this in D3663: Fix node.resolve_network tests.Fri, Sep 12, 17:14
dereckson added a revision: D3663: Fix node.resolve_network tests.
dereckson added a revision: D3664: Deploy the monitoring Vault policy.Fri, Sep 12, 17:19
dereckson added a revision: D3665: Prune unused webserver-content index generator.Fri, Sep 12, 17:46
dereckson added a comment.Fri, Sep 12, 17:50
In T2123#32403, @dereckson wrote:

Tests fix commits will be aggregated in datacube T2123-improve-tests-suite branch, so we can have a look of what's remaining to fix.

All the tests now pass in that branch.

dereckson moved this task from Backlog to Pending review on the Servers board.Fri, Sep 12, 17:51
dereckson moved this task from Backlog to Ops on the Technical debt board.
dereckson added a revision: D3685: Avoid importlib.machinery.SourceFileLoader load_module use.Wed, Sep 17, 16:42
dereckson mentioned this in D3685: Avoid importlib.machinery.SourceFileLoader load_module use.
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator