Paths

Table of Contentst

Differential D3690

Test DNS zone files
ClosedPublic
Actions

Authored by dereckson on Sep 18 2025, 16:38.

Tags

None

Referenced Files

	F52342315: D3690.id9601.diff
	Fri, Oct 2, 02:08

	F52309745: D3690.id9547.diff
	Thu, Oct 1, 20:14

	F52309728: D3690.id9546.diff
	Thu, Oct 1, 20:13

	F52308716: D3690.id9653.diff
	Thu, Oct 1, 19:59

	F52275269: D3690.id9547.diff
	Thu, Oct 1, 13:15

	F52261917: D3690.id9547.diff
	Thu, Oct 1, 10:50

	F52252452: D3690.id9546.diff
	Thu, Oct 1, 09:03

	F52247883: D3690.id9547.diff
	Thu, Oct 1, 08:15

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1217: Host our DNS servers

Commits

rOPS6524a9a5b726: Test DNS zone files

Summary

Run sanity tests against roles/dns/knot/files/zones content:

do we have zone files defined in pillar?
can they be validated with kzonecheck?

Tests also validate the pillar files for content needed by zone files:

is dns_identity defined?

Test Plan

(cd _tests && make test-roles-dns)

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	_tests/roles/python/dns/test_dns_zones.py:29	E225	flake8 E225
Error	_tests/roles/python/dns/test_dns_zones.py:63	E225	flake8 E225
Error	_tests/roles/python/dns/test_dns_zones.py:77	E303	flake8 E303
Error	_tests/roles/python/dns/test_dns_zones.py:82	E302	flake8 E302
Error	_tests/roles/python/dns/test_dns_zones.py:101	E303	flake8 E303
Error	_tests/roles/python/dns/test_dns_zones.py:106	E302	flake8 E302
Error	_tests/roles/python/dns/test_dns_zones.py:145	E501	flake8 E501
Error	_tests/roles/python/dns/test_dns_zones.py:149	E501	flake8 E501
Error	_tests/roles/python/dns/test_dns_zones.py:158	E501	flake8 E501
Error	_tests/roles/python/dns/test_dns_zones.py:162	E303	flake8 E303
Error	_tests/roles/python/dns/test_dns_zones.py:167	E305	flake8 E305

Unit

No Test Coverage

Branch

tests-dns

Build Status

Buildable 5910
Build 6192: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sep 18 2025, 16:38

dereckson created this revision.

Harbormaster completed remote builds in B5910: Diff 9546.Sep 18 2025, 16:38

black

Harbormaster completed remote builds in B5911: Diff 9547.Sep 18 2025, 16:39

dereckson mentioned this in D3691: Use @ syntax for zone apex.Sep 18 2025, 17:08

dereckson planned changes to this revision.Sep 21 2025, 12:37

dereckson added inline comments.

_tests/roles/python/dns/run_test_dns_zones.sh
20	Write to stderr?
_tests/roles/python/dns/test_dns_zones.py
60

See comments

Harbormaster completed remote builds in B5946: Diff 9601.Sep 22 2025, 20:16

dereckson mentioned this in rOPS00b82a3cae0a: Use @ syntax for zone apex.Sep 22 2025, 21:04

DorianWinty accepted this revision.Oct 6 2025, 05:46

This revision is now accepted and ready to land.Oct 6 2025, 05:46

Closed by commit rOPS6524a9a5b726: Test DNS zone files (authored by dereckson). · Explain WhyOct 10 2025, 22:31

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPS6524a9a5b726: Test DNS zone files.

Revision Contents
Changeset List

Path

Size

_tests/

11 lines

roles/

python/

dns/

run_test_dns_zones.sh

27 lines

test_dns_zones.py

168 lines

roles/

dns/

knot/

2 lines

Diff 9546

_tests/Makefile

Loading...

_tests/roles/python/dns/run_test_dns_zones.sh

Loading...

_tests/roles/python/dns/test_dns_zones.py

Loading...

roles/dns/knot/config.sls

Loading...