Page MenuHomeDevCentral
Differential D3690

Test DNS zone files
ClosedPublic
Actions

Authored by dereckson on Sep 18 2025, 16:38.
Tags
None
Referenced Files
F52948770: D3690.id.diff
Tue, Oct 6, 01:01
F52941951: D3690.diff
Mon, Oct 5, 23:55
F52934043: D3690.id.diff
Mon, Oct 5, 22:40
Unknown Object (File)
Sat, Oct 3, 21:14
Unknown Object (File)
Fri, Oct 2, 19:52
Unknown Object (File)
Fri, Oct 2, 19:51
Unknown Object (File)
Fri, Oct 2, 13:48
Unknown Object (File)
Fri, Oct 2, 02:08
View All Files
Subscribers
None

Details

Reviewers
DorianWinty
Maniphest Tasks
T1217: Host our DNS servers
Commits
rOPS6524a9a5b726: Test DNS zone files
Summary

Run sanity tests against roles/dns/knot/files/zones content:

  • do we have zone files defined in pillar?
  • can they be validated with kzonecheck?

Tests also validate the pillar files for content needed by zone files:

  • is dns_identity defined?

Ref T1217

Test Plan

(cd _tests && make test-roles-dns)

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
tests-dns
Build Status
Buildable 5911
Build 6193: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sep 18 2025, 16:38
dereckson created this revision.
Harbormaster completed remote builds in B5910: Diff 9546.Sep 18 2025, 16:38
dereckson updated this revision to Diff 9547.Sep 18 2025, 16:39

black

Harbormaster completed remote builds in B5911: Diff 9547.Sep 18 2025, 16:39
dereckson mentioned this in D3691: Use @ syntax for zone apex.Sep 18 2025, 17:08
dereckson planned changes to this revision.Sep 21 2025, 12:37
dereckson added inline comments.
_tests/roles/python/dns/run_test_dns_zones.sh
19

Write to stderr?

_tests/roles/python/dns/test_dns_zones.py
59
dereckson updated this revision to Diff 9601.Sep 22 2025, 20:16

See comments

Harbormaster completed remote builds in B5946: Diff 9601.Sep 22 2025, 20:16
dereckson mentioned this in rOPS00b82a3cae0a: Use @ syntax for zone apex.Sep 22 2025, 21:04
DorianWinty accepted this revision.Oct 6 2025, 05:46
This revision is now accepted and ready to land.Oct 6 2025, 05:46
Closed by commit rOPS6524a9a5b726: Test DNS zone files (authored by dereckson). · Explain WhyOct 10 2025, 22:31
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOPS6524a9a5b726: Test DNS zone files.

Revision Contents
Changeset List

PathSize
_tests/
11 lines
roles/
python/
dns/
27 lines
169 lines
roles/
dns/
knot/
2 lines

Diff 9547

View Options

_tests/Makefile

Loading...
View Options

_tests/roles/python/dns/run_test_dns_zones.sh

Loading...
View Options

_tests/roles/python/dns/test_dns_zones.py

Loading...
View Options

roles/dns/knot/config.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator