Paths

Table of Contentst

Differential D4107

Update Black style
ClosedPublic
Actions

Authored by dereckson on Sun, Jun 7, 10:19.

Details

Reviewers

dereckson

Commits

rOPSa827d8bce0ae: Update Black style

Summary

Black style now enforces the number of blank line above a method or class.
As such, our symmetric choice of two blank lines between import and first
definition doesn't comply with black style anymore.

Test Plan

'{path="' + value + '"}' == "{path=\"" + value + "\"}" returns True

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	_modules/node.py:500	E501	flake8 E501
Error	_modules/node.py:527	E501	flake8 E501
Error	_modules/node.py:534	E501	flake8 E501
Error	_modules/rabbitmq_api.py:62	E501	flake8 E501
Error	_tests/pillar/dbserver/test_postgresql.py:70	E501	flake8 E501
Error	roles/core/certificates/files/certbot/utilities/check-letsencrypt-certificates.py:11	E501	flake8 E501
Error	roles/dbserver-pgsql/monitoring/files/check-postgresql-dependencies.py:61	E501	flake8 E501
Error	roles/dbserver-pgsql/monitoring/files/check-postgresql-xml-support.py:53	E501	flake8 E501
Error	roles/devserver/webserver-home/files/setup-web-home.py:54	E501	flake8 E501
Error	roles/mailserver/postfix/files/postfix-to-mailman.py:21	E501	flake8 E501
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:118	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:216	E501	flake8 E501
Error	roles/paas-docker/docker/files/docker-paas-list-containers.py:65	E501	flake8 E501
Error	utils/dump-py-state.py:64	E501	flake8 E501
Error	utils/netbox/document-hypervisors.py:162	E501	flake8 E501
Error	utils/vault/wordpress-provision-secrets.py:105	E501	flake8 E501
Error	utils/vault/wordpress-provision-secrets.py:116	E501	flake8 E501

Unit

No Test Coverage

Branch

black-update

Build Status

Buildable 6715
Build 7003: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sun, Jun 7, 10:19

dereckson created this revision.

Harbormaster completed remote builds in B6715: Diff 10768.Sun, Jun 7, 10:19

Flake8 comments unrelated to Black.

Also:

$ find . -type f -name '*.py' | xargs black
All done! ✨ 🍰 ✨
81 files left unchanged.

As we remove lines, and only amend one, an edit to .git-blame-ignore-revs isn't useful, line around the edit points to c56da24dc in git blame.

This revision is now accepted and ready to land.Sun, Jun 7, 10:22

This revision was landed with ongoing or failed builds.Sun, Jun 7, 10:22

Closed by commit rOPSa827d8bce0ae: Update Black style (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPSa827d8bce0ae: Update Black style.

dereckson mentioned this in D4028: Update Black style.Sun, Jun 7, 10:34

Revision Contents
Changeset List

Path

Size

_modules/

1 line

1 line

1 line

1 line

1 line

_states/

rabbitmq.py

1 line

_tests/

helpers.py

1 line

modules/

test_nano.py

1 line

pillar/

core/

test_users.py

1 line

credentials/

test_vault.py

1 line

dbserver/

test_postgresql.py

1 line

paas/

test_docker.py

1 line

roles/

python/

dns/

test_dns_zones.py

1 line

scripts/

python/

test_clear_video_queue.py

1 line

test_edit_acme_dns_accounts.py

1 line

requirements.txt

2 lines

roles/

core/

certificates/

files/

certbot/

utilities/

check-letsencrypt-certificates.py

1 line

dbserver-pgsql/

monitoring/

files/

check-postgresql-dependencies.py

1 line

check-postgresql-xml-support.py

1 line

devserver/

api-exec/

files/

server.py

1 line

userland-software/

files/

ccache-metrics.py

3 lines

install-clang-format-alias.py

1 line

shell.py

1 line

url.py

1 line

webserver-home/

files/

setup-web-home.py

1 line

mailserver/

postfix/

files/

postfix-to-mailman.py

1 line

monitoring/

checks/

files/

check-github-storage.py

1 line

paas-docker/

containers/

files/

hound/

generate-config.py

1 line

mastodon/

clear-video-queue.py

1 line

sentry/

etc/

sentry.conf.py

1 line

docker/

files/

docker-paas-list-containers.py

1 line

utils/

dump-py-state.py

1 line

netbox/

build-etc-hosts-drake.py

1 line

document-hypervisors.py

1 line

next-uid.py

1 line

nginx/

ranges2geo.py

1 line

show-local-states.py

1 line

templates/

create.py

1 line

vault/

issue-admin-token.py

1 line

wordpress-provision-secrets.py

1 line

Diff 10768

View Options

_modules/convert.py

View Options

_modules/credentials.py

View Options

_modules/network_utils.py

View Options

_modules/node.py

View Options

_modules/rabbitmq_api.py

View Options

_states/rabbitmq.py

View Options

_tests/helpers.py

View Options

_tests/modules/test_nano.py

View Options

_tests/pillar/core/test_users.py

View Options

_tests/pillar/credentials/test_vault.py

View Options

_tests/pillar/dbserver/test_postgresql.py

View Options

_tests/pillar/paas/test_docker.py

View Options

_tests/roles/python/dns/test_dns_zones.py

View Options

_tests/scripts/python/test_clear_video_queue.py

View Options

_tests/scripts/python/test_edit_acme_dns_accounts.py

View Options

requirements.txt

View Options

roles/core/certificates/files/certbot/utilities/check-letsencrypt-certificates.py

View Options

roles/dbserver-pgsql/monitoring/files/check-postgresql-dependencies.py

View Options

roles/dbserver-pgsql/monitoring/files/check-postgresql-xml-support.py

View Options

roles/devserver/api-exec/files/server.py

View Options

roles/devserver/userland-software/files/ccache-metrics.py

View Options

roles/devserver/userland-software/files/install-clang-format-alias.py

View Options

roles/devserver/userland-software/files/shell.py

View Options

roles/devserver/userland-software/files/url.py

View Options

roles/devserver/webserver-home/files/setup-web-home.py

View Options

roles/mailserver/postfix/files/postfix-to-mailman.py

View Options

roles/monitoring/checks/files/check-github-storage.py

View Options

roles/paas-docker/containers/files/hound/generate-config.py

View Options

roles/paas-docker/containers/files/mastodon/clear-video-queue.py

View Options

roles/paas-docker/containers/files/sentry/etc/sentry.conf.py

View Options

roles/paas-docker/docker/files/docker-paas-list-containers.py

View Options

utils/dump-py-state.py

View Options

utils/netbox/build-etc-hosts-drake.py

View Options

utils/netbox/document-hypervisors.py

View Options

utils/next-uid.py

View Options

utils/nginx/ranges2geo.py

View Options

utils/show-local-states.py

View Options

utils/templates/create.py

View Options

utils/vault/issue-admin-token.py

View Options

utils/vault/wordpress-provision-secrets.py

Update Black styleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10768

_modules/convert.py

_modules/credentials.py

_modules/network_utils.py

_modules/node.py

_modules/rabbitmq_api.py

_states/rabbitmq.py

_tests/helpers.py

_tests/modules/test_nano.py

_tests/pillar/core/test_users.py

_tests/pillar/credentials/test_vault.py

_tests/pillar/dbserver/test_postgresql.py

_tests/pillar/paas/test_docker.py

_tests/roles/python/dns/test_dns_zones.py

_tests/scripts/python/test_clear_video_queue.py

_tests/scripts/python/test_edit_acme_dns_accounts.py

requirements.txt

roles/core/certificates/files/certbot/utilities/check-letsencrypt-certificates.py

roles/dbserver-pgsql/monitoring/files/check-postgresql-dependencies.py

roles/dbserver-pgsql/monitoring/files/check-postgresql-xml-support.py

roles/devserver/api-exec/files/server.py

roles/devserver/userland-software/files/ccache-metrics.py

roles/devserver/userland-software/files/install-clang-format-alias.py

roles/devserver/userland-software/files/shell.py

roles/devserver/userland-software/files/url.py

roles/devserver/webserver-home/files/setup-web-home.py

roles/mailserver/postfix/files/postfix-to-mailman.py

roles/monitoring/checks/files/check-github-storage.py

roles/paas-docker/containers/files/hound/generate-config.py

roles/paas-docker/containers/files/mastodon/clear-video-queue.py

roles/paas-docker/containers/files/sentry/etc/sentry.conf.py

roles/paas-docker/docker/files/docker-paas-list-containers.py

utils/dump-py-state.py

utils/netbox/build-etc-hosts-drake.py

utils/netbox/document-hypervisors.py

utils/next-uid.py

utils/nginx/ranges2geo.py

utils/show-local-states.py

utils/templates/create.py

utils/vault/issue-admin-token.py

utils/vault/wordpress-provision-secrets.py

Update Black style
ClosedPublic
Actions

Revision Contents
Changeset List