Paths

Table of Contentst

Differential D478

Style: better compliance with community Ruby coding style guide
ClosedPublic
Actions

Authored by dereckson on Jul 10 2016, 21:27.

Tags

None

Referenced Files

	F3788143: D478.diff
	Tue, Nov 26, 21:27

	F3783019: D478.id1169.diff
	Tue, Nov 26, 01:44

	F3783017: D478.id1168.diff
	Tue, Nov 26, 01:44

	F3782364: D478.id.diff
	Tue, Nov 26, 00:15

	F3781926: D478.diff
	Mon, Nov 25, 22:26

	Unknown Object (File)
	Tue, Nov 19, 13:50

	Unknown Object (File)
	Fri, Nov 15, 15:14

	Unknown Object (File)
	Thu, Nov 14, 17:23

Subscribers

None

Details

Reviewers

Maniphest Tasks

T912: Follow the community Ruby Style Guide

Commits

rTOMMY228d017ece70: Style: better compliance with community Ruby coding style guide

Summary

The following points, detected by Rubocop, are improved:

if !something → unless something
Ruby 1.9 hash syntax is used
is_quality? → quality?
removed extraneous self

Test Plan

Run dashboard, ensure all cards are still available.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1168.Jul 10 2016, 21:27

dereckson retitled this revision from to Style: better compliance with community Ruby coding style guide.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jul 10 2016, 21:28

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2016, 21:28

Closed by commit rTOMMY228d017ece70: Style: better compliance with community Ruby coding style guide (authored by dereckson, committed by dereckson). · Explain WhyJul 10 2016, 21:29

This revision was automatically updated to reflect the committed changes.

dereckson added a task: T912: Follow the community Ruby Style Guide.Jul 11 2016, 14:15

Revision Contents
Changeset List

Path

Size

34 lines

Diff 1169

tommy.rb

Loading...