Paths

Table of Contentst

Differential D478

Style: better compliance with community Ruby coding style guide
ClosedPublic
Actions

Authored by dereckson on Jul 10 2016, 21:27.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jun 18, 19:11

	Unknown Object (File)
	Thu, Jun 18, 13:03

	Unknown Object (File)
	Thu, Jun 18, 12:25

	Unknown Object (File)
	Thu, Jun 18, 10:39

	Unknown Object (File)
	Thu, Jun 18, 07:57

	Unknown Object (File)
	Thu, Jun 18, 05:11

	Unknown Object (File)
	Thu, Jun 18, 03:03

	Unknown Object (File)
	Thu, Jun 18, 01:58

Subscribers

None

Details

Reviewers

Maniphest Tasks

T912: Follow the community Ruby Style Guide

Commits

rTOMMY228d017ece70: Style: better compliance with community Ruby coding style guide

Summary

The following points, detected by Rubocop, are improved:

if !something → unless something
Ruby 1.9 hash syntax is used
is_quality? → quality?
removed extraneous self

Test Plan

Run dashboard, ensure all cards are still available.

Diff Detail

Repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	tommy.rb:32	Metrics/LineLength	RuboCop
Warning	tommy.rb:33	Metrics/LineLength	RuboCop
Warning	tommy.rb:35	Metrics/LineLength	RuboCop
Warning	tommy.rb:36	Metrics/LineLength	RuboCop

Unit

No Test Coverage

Branch

style (branched from master)

Build Status

Buildable 678
Build 798: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1168.Jul 10 2016, 21:27

dereckson retitled this revision from to Style: better compliance with community Ruby coding style guide.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jul 10 2016, 21:28

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2016, 21:28

Closed by commit rTOMMY228d017ece70: Style: better compliance with community Ruby coding style guide (authored by dereckson, committed by dereckson). · Explain WhyJul 10 2016, 21:29

This revision was automatically updated to reflect the committed changes.

dereckson added a task: T912: Follow the community Ruby Style Guide.Jul 11 2016, 14:15

Revision Contents
Changeset List

Path

Size

34 lines

Diff 1168

tommy.rb

Loading...